#435

Optional AADC module still builds unpinned main despite published installer and binaries

OpenDicklesworthstoneopened 22d ago

ACFS's optional, disabled-by-default utils.aadc module still unconditionally clones the default branch and performs a release compilation. The manifest says no install.sh is available, but AADC v0.1.1 has a public installer and four Unix prebuilt archives with SHA256 sidecars. The current route adds avoidable compiler/offload requirements and uses unreleased main source rather than a selected immutable release.

Audited identity and exact route:

  • ACFS source snapshot fcbf4e94db3d66eba5be09c15b5494d215a964e4, module metadata and install body.
  • Authoritative manifest lines 3909–3915: obsolete no-installer comment, shallow default-branch clone, cargo build --release, then cp "${CARGO_TARGET_DIR:-target}/release/aadc" ~/.cargo/bin/.
  • Generated executable surface is scripts/generated/install_tools.sh lines 1963–1969, containing the same source-only commands. This was read, not executed. The authoritative manifest/generator must remain the implementation source; do not patch generated output alone.
  • Module remains optional: true, enabled_by_default: false, and depends on lang.rust. This affects explicit opt-in selection; no default-install outage is inferred.
  • The copy command already respects CARGO_TARGET_DIR. AADC's separate installer defect is different: it hardcodes TMP/src/target/release/aadc after Cargo runs.

Public AADC evidence:

v0.1.1, release ID 383860403, published 2026-09-07T06:05:43Z. The released installer asset 548266355 SHA256 is 3b837c568c3fde8f1e3b9c2278b4bbcae17a073a47856296f695f47ed4d78a1f, matching canonical AADC source at fc233adefebe114483094acec9b7697e192cd363. Linux amd64/arm64 and Darwin amd64/arm64 archives and sidecars exist. The release source commit is 5a0265a06b87c442d4012cfb8af846001af168a1; current main differs. No binary/platform execution was performed here.

Overlap and sequencing:

AADC's open bd-lj8 installer-hardening and bd-5iy real eight-platform/48-cell release-smoke beads already cover exact version pins, source fallback and installer reliability. The existing installer is not currently a fully qualified substitute: it ignores the requested source-build ref and assumes the default Cargo target location. Do not switch ACFS blindly to that unqualified fallback.

ACFS open issue #426 covers general release/factory/native-checker qualification, #433 covers checksum-monitor refusal on an unsafe pinned Bun binary, and #346 tracks floating Rust toolchains (including AADC historically). None specifically documents this obsolete optional AADC source-only integration; link relevant qualification/toolchain issues instead of closing or broadening them. The recorded open ACFS Beads snapshot has no AADC/s2p installer-specific item. Re-check current ownership and issue state before posting or changing anything.

Bounded fix and acceptance plan:

  1. Coordinate the AADC installer hardening with its owner and retain this module's explicit-selection/error semantics. Prefer the verified prebuilt route on supported Unix architectures once qualified, with exact release selection and clear refusal when an unsupported/source-build lane is held.
  2. Change authoritative acfs.manifest.yaml, add/refresh the targeted verified-installer checksum through the supported checksum tooling, regenerate supported install/web metadata with the existing generator, and review exact generated deltas. Do not hand-edit generated shells or unrelated pins.
  3. Run manifest validation, generated drift/checksum/contract checks, selection/error propagation tests, and actual selected-module installation on clean supported Ubuntu 22.04/24.04/26.04 hosts when admitted. Use real GitHub release downloads, retained destinations, exact installed version/help and a small real ASCII correction. Require repeat-install behavior and correct explicitly selected optional failure propagation.
  4. Keep source compilation a separately admitted, pinned-source strict-RCH gate. Current RCH retention issue #95 and native DSR runner issue #17 are independent campaign holds; no bypass or old release exception is implied. No GitHub Actions.

No ACFS edit, checksum change, regenerated source, compiler invocation, factory/installer runtime test or push was performed in this audit. Published asset metadata is only evidence that a prebuilt route exists.

Recorded during the owner-authorized release preparation audit. GitHub Actions are disabled; no workflow was dispatched. The listed source findings and future acceptance criteria do not establish release readiness.

Activity

0

No activity yet.