#409

disable callout to api.github.com

Openandreasschulzeopened 1y ago

the code try to connect to api.github.com (to check for a new version I think)

https://github.com/Joxit/docker-registry-ui/blob/main/src/components/version-notification.riot#L62-L89

is it possible to disable this feature to avoid the connection attempt at all?

Activity

3
Joxit1y ago

Hi,

Yes, this piece of code is for checking new updates, there are no options to disable it.

Why would you remove it ?

ygerlach1y ago

Some people like their computer not to make unasked connections. Especially to external servers outside their control. And i guess some people might run this container in a environment where no access to github (or the general internet) is available anyways, it makes sense to allow them to disable this.

ParticleG1y ago

Hi,

Yes, this piece of code is for checking new updates; there are no options to turn it off.

Why would you remove it?

Hi there, we deployed your image in an air-gapped environment that does not have access to github.com. It would be nice if we could pass an environment variable like DISABLE_UPDATE_CHECK when starting the container. Otherwise, the browser just kept getting a connection timeout error.