78:T2bed, ## Description On macOS 15+ (Sequoia / Darwin 24+), status bar item tracking routed through `FrontBoardServices` and `NSSceneStatusItem` delivers `NSEventTypeAppKitDefined` (type 13, printed as `KitDefined`) events when interacting with the menu bar icon. When Qt's Cocoa platform plugin (`libqcocoa.dylib` in `QCocoaSystemTrayIcon`) receives the internal notification from `NSMenuTrackingSession`, it directly invokes `[NSApp.currentEvent clickCount]` without verifying whether the event is actually a mouse event. In AppKit, invoking `-[NSEvent clickCount]` on a non-mouse event raises an `NSInternalInconsistencyException`, terminating Sunshine with an unhandled exception abort: ``` *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid message sent to event "NSEvent: type=KitDefined loc=(0,900) time=555614.8 flags=0x40 win=0x0 winNum=0 ctxt=0x0 subtype=2 data1=0 data2=64"' *** First throw call stack: ( 0 CoreFoundation 0x000000018fb3a8c0 __exceptionPreprocess + 176 1 libobjc.A.dylib 0x000000018f59860c objc_exception_throw + 88 2 Foundation 0x00000001912814d8 -[NSCalendarDate initWithCoder:] + 0 3 AppKit 0x0000000194218f80 -[NSEvent clickCount] + 152 4 libqcocoa.dylib 0x00000001076bb49c qt_plugin_instance + 186712 5 CoreFoundation 0x000000018fabf1a0 __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 148 6 CoreFoundation 0x000000018fb4e394 ___CFXRegistrationPost_block_invoke + 92 7 CoreFoundation 0x000000018fb4e2d8 _CFXRegistrationPost + 440 8 CoreFoundation 0x000000018fa8b3d0 _CFXNotificationPost + 688 9 Foundation 0x000000019117c38c -[NSNotificationCenter postNotificationName:object:userInfo:] + 88 10 AppKit 0x000000019462d154 -[NSMenuTrackingSession sendBeginTrackingNotifications] + 188 11 AppKit 0x0000000194634b98 -[NSMenuTrackingSession beginTrackingSession:] + 644 12 AppKit 0x00000001945e1bac +[NSContextMenuImpl presentPopup:fromView:withContext:animated:async:completionBlock:] + 432 13 AppKit 0x0000000194926880 _NSPopUpMenu + 1992 14 AppKit 0x0000000194925fe0 -[NSCocoaMenuImpl popUpMenu:atLocation:width:view:selectedItemIndexProvider:font:positioningRect:flags:options:] + 432 15 AppKit 0x0000000194925e08 -[NSCocoaMenuImpl popUpMenu:atLocation:width:forView:withSelectedItem:withFont:withFlags:withOptions:] + 96 16 AppKit 0x00000001948e682c +[NSStatusBarButtonCell popUpStatusBarMenu:ofItem:ofBar:inRect:ofView:withEvent:] + 744 17 AppKit 0x00000001948eed1c -[NSStatusItem popUpStatusItemMenu:] + 108 18 AppKit 0x00000001948ef348 -[NSStatusItem _beginExpandedInterfaceSession:] + 600 19 AppKit 0x00000001946ba60c -[NSSceneStatusItem _beginExpandedInterfaceSession:] + 192 20 AppKit 0x00000001946b91b0 __33-[NSSceneStatusItem _setupScene:]_block_invoke.25 + 320 21 AppKit 0x0000000194f06618 __swift_closure_destructor.106 + 28764 22 AppKit 0x0000000194f06794 __swift_closure_destructor.106 + 29144 23 FrontBoardServices 0x00000001ac1a7cc8 -[FBSSceneObserver scene:handlePrivateActions:] + 80 24 FrontBoardServices 0x00000001ac16b864 -[FBSScene updater:didReceiveActions:forExtension:] + 736 25 FrontBoardServices 0x00000001ac193e28 __71-[FBSWorkspaceScenesClient sceneID:sendActions:toExtension:completion:]_block_invoke + 204 26 FrontBoardServices 0x00000001ac14ebbc -[FBSWorkspace _calloutQueue_executeCalloutFromSource:withBlock:] + 180 27 libdispatch.dylib 0x000000018f8625a0 _dispatch_client_callout + 16 28 libdispatch.dylib 0x000000018f84d700 _dispatch_block_invoke_direct + 284 29 BoardServices 0x00000001ac236ca4 __BSSERVICEMAINRUNLOOPQUEUE_IS_CALLING_OUT_TO_A_BLOCK__ + 48 30 BoardServices 0x00000001ac235ac8 BSServiceMainRunLoopSourceHandler + 232 31 CoreFoundation 0x000000018faca944 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28 32 CoreFoundation 0x000000018faca8d8 __CFRunLoopDoSource0 + 224 33 CoreFoundation 0x000000018faca610 __CFRunLoopDoSources0 + 232 34 CoreFoundation 0x000000018fac91e0 __CFRunLoopRun + 832 35 CoreFoundation 0x000000018fba382c _CFRunLoopRunSpecificWithOptions + 536 36 HIToolbox 0x000000019cefc590 RunCurrentEventLoopInMode + 320 37 HIToolbox 0x000000019ceff91c ReceiveNextEventCommon + 492 38 HIToolbox 0x000000019d082380 _BlockUntilNextEventMatchingListInMode + 48 39 AppKit 0x00000001943c329c _DPSBlockUntilNextEventMatchingListInMode + 292 40 AppKit 0x00000001940804fc _DPSNextEvent + 580 41 AppKit 0x00000001948f8748 -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 780 42 AppKit 0x00000001948f826c -[NSApplication(NSEventRouting) nextEventMatchingMask:untilDate:inMode:dequeue:] + 292 43 AppKit 0x000000019407390c -[NSApplication run] + 396 44 libqcocoa.dylib 0x000000010769b99c qt_plugin_instance + 56920 45 QtCore 0x00000001071a6ba0 _ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE + 588 46 QtCore 0x000000010719d1a8 _ZN16QCoreApplication4execEv + 228 47 Sunshine 0x0000000105028110 _ZN10QtTrayMenu4loopEi + 232 48 Sunshine 0x000000010456f53c _Z14mainThreadLoopRKNSt3__110shared_ptrIN4safe7event_tIbEEEE + 212 49 Sunshine 0x0000000104570d90 main + 5668 50 dyld 0x000000018f633e80 start + 6688 ) libc++abi: terminating due to uncaught exception of type NSException ``` This PR resolves the crash by: 1. Adding `platf::install_event_compatibility_fixes()` in `src/platform/macos/misc.mm`, which swizzles `-[NSEvent clickCount]` using an Objective-C category. 2. For mouse event types (`LeftMouseDown/Up`, `RightMouseDown/Up`, `OtherMouseDown/Up`), the original implementation is called with `@try / @catch` fallback. 3. For non-mouse events (such as `NSEventTypeAppKitDefined`), it immediately returns `1` instead of throwing. 4. Calling `platf::install_event_compatibility_fixes()` early in `src/main.cpp` and prior to `tray_init()` in `src/system_tray.cpp`. ### Screenshot ### Issues Fixed or Closed #### Roadmap Issues ## Testing Added automated unit regression tests in `tests/unit/platform/macos/test_event_compat.mm` (`MacosEventCompatTest`): - `IdempotentInstallation`: Verifies safe idempotent execution across multiple setup calls. - `NonMouseEventClickCountReturnsFallbackWithoutThrowing`: Verifies that querying `clickCount` on `NSEventTypeAppKitDefined` and `NSEventTypeSystemDefined` events returns `1` without throwing `NSInternalInconsistencyException`. - `MouseEventClickCountPreserved`: Verifies that single, double, and right-click counts are correctly preserved for mouse events. Commands run: ```bash cmake --build cmake-build-debug --target test_sunshine -j8 ./cmake-build-debug/tests/test_sunshine --gtest_filter="Macos*:SystemTrayTest.*" uv run --locked lb-update-clang-format ``` All 16 tests in `MacosPermissionsTest`, `SystemTrayTest`, `MacosAudioPermissionTest`, and `MacosEventCompatTest` passed. ## Type of Change - [ ] **feat**: New feature (non-breaking change which adds functionality) - [X] **fix**: Bug fix (non-breaking change which fixes an issue) - [ ] **docs**: Documentation only changes - [ ] **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.) - [ ] **refactor**: Code change that neither fixes a bug nor adds a feature - [ ] **perf**: Code change that improves performance - [ ] **test**: Adding missing tests or correcting existing tests - [ ] **build**: Changes that affect the build system or external dependencies - [ ] **ci**: Changes to CI configuration files and scripts - [ ] **chore**: Other changes that don't modify src or test files - [ ] **revert**: Reverts a previous commit - [ ] **BREAKING CHANGE**: Introduces a breaking change (can be combined with any type above) ## Checklist - [x] Code follows the style guidelines of this project - [x] Code has been self-reviewed - [x] Code has been commented, particularly in hard-to-understand areas - [x] Code docstring/documentation-blocks for new or existing methods/components have been added or updated - [x] Tests have been added or updated for new or modified functionality, including regression tests for bug fixes ### AI Usage See our [AI usage policy](https://docs.lizardbyte.dev/latest/developers/contributing.html#ai-usage). - [X] AI tools were used while preparing this PR AI assisted in analyzing the macOS `NSInternalInconsistencyException` crash call stack, implementing the AppKit swizzle compatibility shim, and developing unit tests. This pull request was generated by Antigravity, Gemini 3.8 Flash, high thinking level.62:["$","$L75",null,{"entries":[{"key":["platform",{"userId":"anon"},"pulls","page",{"owner":"LizardByte","repo":"Sunshine","pullNumber":5901}],"data":{"repositoryId":"3992","detail":{"author":{"avatarUrl":"https://cdn.trylle.com/media/images/7799b00e1a16a32adeef4b417460ca2c?key=AdI7mT%2FR%2FbGZjdsf23h7LAWP1qZV0XxWh1nWrqDOJtHhQD1IYCVjYI4K3emSKr0rFV3e6U83dqIwdBQR6ErfdDGM%2BUXaezxwVIw38DgCszUWAl2kTIUesAdRIe12HTTFZDIsPSaT5bJ9JTNZq88Tw3pPTi6BZANJKXi7S8t7%2BRegJlXEfhbE9%2Fox","externalProvider":"github","login":"eduardomozart","type":"User","url":"https://github.com/eduardomozart"},"authorId":"2974895","baseRefName":"master","closedAt":null,"comments":1,"createdAt":"2026-10-11T18:19:51Z","headRefName":"unknown repository","id":"4934307","isDraft":false,"labels":[],"number":5901,"repository":{"name":"Sunshine","owner":"LizardByte","provider":"forgejo"},"state":"open","title":"fix(macos): handle non-mouse events in clickCount to prevent system tray crash","updatedAt":"2026-10-11T18:32:41Z","url":"https://trylle.com/LizardByte/Sunshine/pulls/5901","body":"$78","additions":173,"deletions":0,"changedFiles":5,"commits":2,"reviewComments":0,"headSha":"26e47664a48eb9b82aadd9eb580e08cc68fa1b28","baseSha":"a679b059096bcdd502e2192ce4f6a3c3732fbaae","headRepoOwner":"LizardByte","headRepoName":"Sunshine","isMerged":false,"mergeCommitSha":null,"mergedBy":null,"mergeable":true,"mergeableState":"clean","conflictingFiles":null,"requestedTeams":[],"requestedReviewers":[],"graphqlId":"issue:5901"},"comments":[{"id":26874257,"graphqlId":"26874257","body":"❌ The last analysis has failed.\n\n[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=LizardByte_Sunshine&pullRequest=5901)","createdAt":"2026-10-11T18:32:40Z","author":{"avatarUrl":"https://cdn.trylle.com/media/images/ffba2eae3878387d344176f3a6e03729?key=ASDUdHAAsxJIAzAhbbYTxbs1BE8boDosy7WO7CO6xXE%2Fxi90ansATxCFdbDT9%2FASXlT6s5z9DHN7VIv965csx7KvK%2FxHWyAwh%2FLfiaj%2BZjXYlqI1smSZf%2FKXF8%2BA8Gg4x9FgZ9IJx3aycXtKcw%2BjBlX4b8sfj%2Fcj6oy6PGJ3EzgTdt5YNoI9FE0b%2Fw%3D%3D","externalProvider":"github","login":"sonarqubecloud[bot]","type":"Bot","url":"https://github.com/apps/sonarqubecloud"}}],"commits":[{"sha":"26e47664a48eb9b82aadd9eb580e08cc68fa1b28","message":"Merge branch 'master' into fix/macos-tray-clickcount-crash","createdAt":"2026-10-11T15:20:28-03:00","author":{"avatarUrl":"","login":"","name":"Eduardo Mozart de Oliveira","type":"User","url":""},"verification":{"verified":false,"reason":"gpg.error.no_gpg_keys_found"}},{"sha":"faadcbf24f499cec7d4a9ab2fb40e8ebbffbbb8e","message":"fix(macos): handle non-mouse events in clickCount to prevent status item crash\n\nOn macOS 15+, interactions with the system tray icon routed through FrontBoardServices and NSSceneStatusItem deliver KitDefined (NSEventTypeAppKitDefined) events. Qt's Cocoa platform plugin (libqcocoa) accesses -[NSEvent clickCount] directly without verifying that the event is a mouse event, throwing an NSInternalInconsistencyException and terminating Sunshine.\n\nInstall an AppKit event compatibility swizzle on -[NSEvent clickCount] that safely returns 1 for non-mouse events and falls back gracefully for mouse events, preventing the crash while preserving genuine click counts.\n","createdAt":"2026-10-11T15:15:26-03:00","author":{"avatarUrl":"","login":"","name":"E","type":"User","url":""},"verification":{"verified":false,"reason":"gpg.error.not_signed_commit"}}],"events":[],"reviews":[],"stackEvents":[],"commentPagination":{"totalCount":1,"perPage":30,"loadedPages":[1]},"eventPagination":{"loadedPages":[1],"hasMore":false},"headRefDeleted":false},"fetchedAt":1793417197399}],"children":"$L79"}] 64:null 6b:[["$","title","0",{"children":"Commits · fix(macos): handle non-mouse events in clickCount to prevent system tray crash · LizardByte/Sunshine | Trylle"}],["$","meta","1",{"name":"description","content":"Commits on fix(macos): handle non-mouse events in clickCount to prevent system tray crash (#5901) in LizardByte/Sunshine."}],["$","meta","2",{"name":"application-name","content":"Trylle"}],["$","link","3",{"rel":"manifest","href":"/manifest.json","crossOrigin":"$undefined"}],["$","meta","4",{"name":"keywords","content":"Commits · fix(macos): handle non-mouse events in clickCount to prevent system tray crash · LizardByte/Sunshine, LizardByte/Sunshine, LizardByte/Sunshine repository, Sunshine, C++ repository, source code, trylle, agent-native git platform, git platform for agents and humans, git platform for ai agents, coding agent pull requests, ai code review, repository automation, stacked pull requests, two-way github sync, github-compatible actions, try cli"}],["$","meta","5",{"name":"robots","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","6",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","7",{"name":"googlebot","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","8",{"name":"twitter:domain","content":"trylle.com"}],["$","meta","9",{"name":"twitter:url","content":"https://trylle.com/LizardByte/Sunshine/pulls/5901/commits"}],["$","link","10",{"rel":"canonical","href":"https://trylle.com/LizardByte/Sunshine/pulls/5901/commits"}],["$","meta","11",{"name":"format-detection","content":"telephone=no"}],["$","meta","12",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","13",{"name":"apple-mobile-web-app-title","content":"Trylle"}],["$","meta","14",{"name":"apple-mobile-web-app-status-bar-style","content":"black-translucent"}],["$","meta","15",{"property":"og:title","content":"Commits · fix(macos): handle non-mouse events in clickCount to prevent system tray crash · LizardByte/Sunshine | Trylle"}],["$","meta","16",{"property":"og:description","content":"Commits on fix(macos): handle non-mouse events in clickCount to prevent system tray crash (#5901) in LizardByte/Sunshine."}],["$","meta","17",{"property":"og:url","content":"https://trylle.com/LizardByte/Sunshine/pulls/5901/commits"}],["$","meta","18",{"property":"og:site_name","content":"Trylle"}],["$","meta","19",{"property":"og:locale","content":"en_US"}],["$","meta","20",{"property":"og:image","content":"https://trylle.com/api/og.png?kind=repo&owner=LizardByte&repo=Sunshine"}],["$","meta","21",{"property":"og:image:secure_url","content":"https://trylle.com/api/og.png?kind=repo&owner=LizardByte&repo=Sunshine"}],["$","meta","22",{"property":"og:image:type","content":"image/png"}],["$","meta","23",{"property":"og:image:width","content":"1200"}],["$","meta","24",{"property":"og:image:height","content":"630"}],["$","meta","25",{"property":"og:image:alt","content":"LizardByte/Sunshine repository preview on Trylle"}],["$","meta","26",{"property":"og:type","content":"website"}],["$","meta","27",{"name":"twitter:card","content":"summary_large_image"}],["$","meta","28",{"name":"twitter:site","content":"@trylle"}],["$","meta","29",{"name":"twitter:title","content":"Commits · fix(macos): handle non-mouse events in clickCount to prevent system tray crash · LizardByte/Sunshine | Trylle"}],["$","meta","30",{"name":"twitter:description","content":"Commits on fix(macos): handle non-mouse events in clickCount to prevent system tray crash (#5901) in LizardByte/Sunshine."}],["$","meta","31",{"name":"twitter:image","content":"https://trylle.com/api/og.png?kind=repo&owner=LizardByte&repo=Sunshine"}],["$","meta","32",{"name":"twitter:image:alt","content":"LizardByte/Sunshine repository preview on Trylle"}],["$","link","33",{"rel":"icon","href":"/favicon.png","type":"image/png"}],"$L7a","$L7b","$L7c"]

Commits on Sun, Oct 11, 2026