78:T11e8, ## Description `util::from_hex` sized its output as `digit_count / 2`, so when a value had an odd number of hex digits the leading digit was dropped. Through the config parser (`parse_config_integer` and `list_int_f`), this gives: - `min_threads = 0x8` is parsed as `0` - `keybindings = [0x9, 0xA0]` maps key `0` to `0xA0` instead of key `0x9` - `keybindings = [0x1B, 0x123]` maps `0x1B` to `0x23` instead of `0x123` The fix rounds the byte count up and treats the missing high nibble of the last byte as zero, so an odd-length value reads as if it had a leading `0`. Even-length input and the existing truncation of over-long input are unchanged. The pairing salt is the only other caller and always passes exactly 32 digits. ### Screenshot ### Issues Fixed or Closed #### Roadmap Issues ## Testing Added `UtilityFromHexTests.OddDigitCountReadsTheLeadingDigitAsTheHighNibble` (`"8"`, `"ABC"` in both byte orders, `"1:2:3"` with separators). I built `test_sunshine` on Linux (Ubuntu 26.04, Debug) and ran `--gtest_filter=UtilityFromHexTests.*:ConfigPersistenceTest.*`, together with a local, uncommitted config test that applies `min_threads = 0x8` and `keybindings = [0x9, 0xA0, 0x1B, 0x123]` through `config::apply_config_for_test`: - on master: both tests fail (`from_hex("8")` is `0`, `min_threads` is `0`, there is no binding for `0x9`, and `0x1B` maps to `35`) - with the fix: all 12 selected tests pass I did not run the Windows or macOS builds. ## Type of Change - [ ] **feat**: New feature (non-breaking change which adds functionality) - [x] **fix**: Bug fix (non-breaking change which fixes an issue) - [ ] **docs**: Documentation only changes - [ ] **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.) - [ ] **refactor**: Code change that neither fixes a bug nor adds a feature - [ ] **perf**: Code change that improves performance - [ ] **test**: Adding missing tests or correcting existing tests - [ ] **build**: Changes that affect the build system or external dependencies - [ ] **ci**: Changes to CI configuration files and scripts - [ ] **chore**: Other changes that don't modify src or test files - [ ] **revert**: Reverts a previous commit - [ ] **BREAKING CHANGE**: Introduces a breaking change (can be combined with any type above) ## Checklist - [x] Code follows the style guidelines of this project - [x] Code has been self-reviewed - [ ] Code has been commented, particularly in hard-to-understand areas - [x] Code docstring/documentation-blocks for new or existing methods/components have been added or updated - [x] Tests have been added or updated for new or modified functionality, including regression tests for bug fixes ### AI Usage See our [AI usage policy](https://docs.lizardbyte.dev/latest/developers/contributing.html#ai-usage). - [x] AI tools were used while preparing this PR Found by a defect-hunting pipeline I build and run ([Dev-next-gen](https://github.com/Dev-next-gen)), using Claude Code with Anthropic's Claude Opus 5.5. > This PR was generated by Claude Code, Claude Opus 5.5, low thinking level 79:Tc09,## [![Quality Gate Passed](https://cdn.trylle.com/media/images/9c421b538b25f3b09f4b2fe2b0372ec2?key=AcQi5aACo4g%2FYo5l5IjHF3xVl6%2FNs4GJqvnQmK1WYQSdtSdRF26f%2FHvQaxVtYfwO5Zmn8dluvsUfc7rMx%2B%2FgQY2OVykvJejXvd9AGYYByqXGzgFAz8gNAGxDHrnoHKtqik9jZGG8QAdOiWU9mFubBHZXaF9DzWU0BmQyy0MI3IUIg8dPDcYRSwg1fpo1NafBvh5XrY6twS%2B7azc0BlfnOuF%2F1fUWs5kIgW%2Fyqnll0eMqf1%2BqbdHuUxive7nB4cFYbX1HRO8%3D "Quality Gate Passed")](https://sonarcloud.io/dashboard?id=LizardByte_Sunshine&pullRequest=5966) **Quality Gate passed** Issues\ ![](https://cdn.trylle.com/media/images/1f80bcb90d79b2b11bb739f48a001eba?key=AUC4JpfjThVa%2Bs177EUoO7i8HgbzCRl8Z01fv0xPDZPLrH%2BDQmUptp2xqyXz6Ry5UVz15ge3hfUJfcrNsco49HOerENB6eluOhBp2S6N6eD%2BR8aS31oqgsuMjumS%2FmD8yI8EO6a6pU6kCSlBJSXMdzHQdpi2f29zd6J3eWkDgK27I67k4Q%2FGj8yrJg24QPoLAitYTBYgMAOhTN%2FUCC%2FmZ0m0c0v6pN10QUhZhOgt%2BmAQ "") [0 New issues](https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&pullRequest=5966&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)\ ![](https://cdn.trylle.com/media/images/2dc6921822f23cc8f5227994feb4f3a1?key=Ac0A%2B0GOiKtG7s6yUOkdAw93Omn2d6UW4CeD2L0U%2BJBRKNXLhiTbhcAYui4CWhVpOt5sS%2FIpI5GuMUAr%2BR7rVdKH%2BhxG6gKozNa21fwbQxSdpTU%2FjZ2iFl9kDiolBU4S%2BRFIeFGghV92lOKfCd6%2BYiGPTNPcoNmsgSbkTS3%2FbidmrAdQOrK9LWMRC%2FNHb3Q89TG%2B6T73DUYy9yDpnhpnR17g1F78itSkkEQd60W2pU9pWj4%3D "") [0 Accepted issues](https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&pullRequest=5966&issueStatuses=ACCEPTED) Measures\ ![](https://cdn.trylle.com/media/images/1f80bcb90d79b2b11bb739f48a001eba?key=AUC4JpfjThVa%2Bs177EUoO7i8HgbzCRl8Z01fv0xPDZPLrH%2BDQmUptp2xqyXz6Ry5UVz15ge3hfUJfcrNsco49HOerENB6eluOhBp2S6N6eD%2BR8aS31oqgsuMjumS%2FmD8yI8EO6a6pU6kCSlBJSXMdzHQdpi2f29zd6J3eWkDgK27I67k4Q%2FGj8yrJg24QPoLAitYTBYgMAOhTN%2FUCC%2FmZ0m0c0v6pN10QUhZhOgt%2BmAQ "") [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=LizardByte_Sunshine&pullRequest=5966&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)\ ![](https://cdn.trylle.com/media/images/1f80bcb90d79b2b11bb739f48a001eba?key=AUC4JpfjThVa%2Bs177EUoO7i8HgbzCRl8Z01fv0xPDZPLrH%2BDQmUptp2xqyXz6Ry5UVz15ge3hfUJfcrNsco49HOerENB6eluOhBp2S6N6eD%2BR8aS31oqgsuMjumS%2FmD8yI8EO6a6pU6kCSlBJSXMdzHQdpi2f29zd6J3eWkDgK27I67k4Q%2FGj8yrJg24QPoLAitYTBYgMAOhTN%2FUCC%2FmZ0m0c0v6pN10QUhZhOgt%2BmAQ "") [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=LizardByte_Sunshine&pullRequest=5966&metric=new_coverage&view=list)\ ![](https://cdn.trylle.com/media/images/1f80bcb90d79b2b11bb739f48a001eba?key=AUC4JpfjThVa%2Bs177EUoO7i8HgbzCRl8Z01fv0xPDZPLrH%2BDQmUptp2xqyXz6Ry5UVz15ge3hfUJfcrNsco49HOerENB6eluOhBp2S6N6eD%2BR8aS31oqgsuMjumS%2FmD8yI8EO6a6pU6kCSlBJSXMdzHQdpi2f29zd6J3eWkDgK27I67k4Q%2FGj8yrJg24QPoLAitYTBYgMAOhTN%2FUCC%2FmZ0m0c0v6pN10QUhZhOgt%2BmAQ "") [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=LizardByte_Sunshine&pullRequest=5966&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=LizardByte_Sunshine&pullRequest=5966) 62:["$","$L75",null,{"entries":[{"key":["platform",{"userId":"anon"},"pulls","page",{"owner":"LizardByte","repo":"Sunshine","pullNumber":5966}],"data":{"repositoryId":"3992","detail":{"author":{"avatarUrl":"https://cdn.trylle.com/media/images/3e55f64b08db8bdb465e6fa4a94c1ce2?key=Afjqw3U5JxmYIfJJ3YkETHAxHeDLbK4lElwMp%2FulDAj2MfwsybT4GiDl8RKRJJ2ppUYVBthtHEO1MJQAXvD%2Bx53Z3O7zwTW7sh42xJh0Lm0gG2YSGUK7uTUDL8cM6m30JgqhmvCx15OjXHLjerU3s9zr8hPhGy%2Bs1%2Fl%2BuzFFT6TgH%2FZTBUtj7Mjf1PE%3D","externalProvider":"github","login":"Dev-next-gen","type":"User","url":"https://github.com/Dev-next-gen"},"authorId":"188639646","baseRefName":"master","closedAt":null,"comments":2,"createdAt":"2026-10-20T14:06:27Z","headRefName":"Dev-next-gen/fix/from-hex-odd-digit-count","id":"4940930","isDraft":false,"labels":[],"number":5966,"repository":{"name":"Sunshine","owner":"LizardByte","provider":"forgejo"},"state":"open","title":"fix(utility): read an odd number of hex digits as a leading zero nibble","updatedAt":"2026-10-20T14:19:32Z","url":"https://trylle.com/LizardByte/Sunshine/pulls/5966","body":"$78","additions":18,"deletions":4,"changedFiles":2,"commits":1,"reviewComments":0,"headSha":"22304acf497545e0ba1c585e4a92553538e1fc60","baseSha":"a679b059096bcdd502e2192ce4f6a3c3732fbaae","headRepoOwner":"LizardByte","headRepoName":"Sunshine","isMerged":false,"mergeCommitSha":null,"mergedBy":null,"mergeable":true,"mergeableState":"clean","conflictingFiles":null,"requestedTeams":[],"requestedReviewers":[],"graphqlId":"issue:5966"},"comments":[{"id":26907332,"graphqlId":"26907332","body":"> This PR was generated by Claude Code, Claude Opus 5.5, low thinking level","createdAt":"2026-10-20T14:06:36Z","author":{"avatarUrl":"https://cdn.trylle.com/media/images/3e55f64b08db8bdb465e6fa4a94c1ce2?key=Afjqw3U5JxmYIfJJ3YkETHAxHeDLbK4lElwMp%2FulDAj2MfwsybT4GiDl8RKRJJ2ppUYVBthtHEO1MJQAXvD%2Bx53Z3O7zwTW7sh42xJh0Lm0gG2YSGUK7uTUDL8cM6m30JgqhmvCx15OjXHLjerU3s9zr8hPhGy%2Bs1%2Fl%2BuzFFT6TgH%2FZTBUtj7Mjf1PE%3D","externalProvider":"github","login":"Dev-next-gen","type":"User","url":"https://github.com/Dev-next-gen"}},{"id":26907333,"graphqlId":"26907333","body":"$79","createdAt":"2026-10-20T14:19:32Z","author":{"avatarUrl":"https://cdn.trylle.com/media/images/ffba2eae3878387d344176f3a6e03729?key=ASDUdHAAsxJIAzAhbbYTxbs1BE8boDosy7WO7CO6xXE%2Fxi90ansATxCFdbDT9%2FASXlT6s5z9DHN7VIv965csx7KvK%2FxHWyAwh%2FLfiaj%2BZjXYlqI1smSZf%2FKXF8%2BA8Gg4x9FgZ9IJx3aycXtKcw%2BjBlX4b8sfj%2Fcj6oy6PGJ3EzgTdt5YNoI9FE0b%2Fw%3D%3D","externalProvider":"github","login":"sonarqubecloud[bot]","type":"Bot","url":"https://github.com/apps/sonarqubecloud"}}],"commits":[{"sha":"22304acf497545e0ba1c585e4a92553538e1fc60","message":"fix(utility): read an odd number of hex digits as a leading zero nibble\n\nfrom_hex sized its buffer as digit_count / 2, so the leading digit of an\nodd-length value was dropped. A config value such as min_threads = 0x8\nparsed as 0, and keybindings = [0x9, 0xA0] mapped key 0 instead of 0x9.\n","createdAt":"2026-10-20T14:02:27Z","author":{"avatarUrl":"","login":"","name":"leoca","type":"User","url":""},"verification":{"verified":false,"reason":"gpg.error.no_gpg_keys_found"}}],"events":[],"reviews":[],"stackEvents":[],"commentPagination":{"totalCount":2,"perPage":30,"loadedPages":[1]},"eventPagination":{"loadedPages":[1],"hasMore":false},"headRefDeleted":false},"fetchedAt":1793417209072}],"children":"$L7a"}] 64:null 6b:[["$","title","0",{"children":"Commits · fix(utility): read an odd number of hex digits as a leading zero nibble · LizardByte/Sunshine | Trylle"}],["$","meta","1",{"name":"description","content":"Commits on fix(utility): read an odd number of hex digits as a leading zero nibble (#5966) in LizardByte/Sunshine."}],["$","meta","2",{"name":"application-name","content":"Trylle"}],["$","link","3",{"rel":"manifest","href":"/manifest.json","crossOrigin":"$undefined"}],["$","meta","4",{"name":"keywords","content":"Commits · fix(utility): read an odd number of hex digits as a leading zero nibble · LizardByte/Sunshine, LizardByte/Sunshine, LizardByte/Sunshine repository, Sunshine, C++ repository, source code, trylle, agent-native git platform, git platform for agents and humans, git platform for ai agents, coding agent pull requests, ai code review, repository automation, stacked pull requests, two-way github sync, github-compatible actions, try cli"}],["$","meta","5",{"name":"robots","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","6",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","7",{"name":"googlebot","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","8",{"name":"twitter:domain","content":"trylle.com"}],["$","meta","9",{"name":"twitter:url","content":"https://trylle.com/LizardByte/Sunshine/pulls/5966/commits"}],["$","link","10",{"rel":"canonical","href":"https://trylle.com/LizardByte/Sunshine/pulls/5966/commits"}],["$","meta","11",{"name":"format-detection","content":"telephone=no"}],["$","meta","12",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","13",{"name":"apple-mobile-web-app-title","content":"Trylle"}],["$","meta","14",{"name":"apple-mobile-web-app-status-bar-style","content":"black-translucent"}],["$","meta","15",{"property":"og:title","content":"Commits · fix(utility): read an odd number of hex digits as a leading zero nibble · LizardByte/Sunshine | Trylle"}],["$","meta","16",{"property":"og:description","content":"Commits on fix(utility): read an odd number of hex digits as a leading zero nibble (#5966) in LizardByte/Sunshine."}],["$","meta","17",{"property":"og:url","content":"https://trylle.com/LizardByte/Sunshine/pulls/5966/commits"}],["$","meta","18",{"property":"og:site_name","content":"Trylle"}],["$","meta","19",{"property":"og:locale","content":"en_US"}],["$","meta","20",{"property":"og:image","content":"https://trylle.com/api/og.png?kind=repo&owner=LizardByte&repo=Sunshine"}],["$","meta","21",{"property":"og:image:secure_url","content":"https://trylle.com/api/og.png?kind=repo&owner=LizardByte&repo=Sunshine"}],["$","meta","22",{"property":"og:image:type","content":"image/png"}],["$","meta","23",{"property":"og:image:width","content":"1200"}],["$","meta","24",{"property":"og:image:height","content":"630"}],["$","meta","25",{"property":"og:image:alt","content":"LizardByte/Sunshine repository preview on Trylle"}],["$","meta","26",{"property":"og:type","content":"website"}],["$","meta","27",{"name":"twitter:card","content":"summary_large_image"}],["$","meta","28",{"name":"twitter:site","content":"@trylle"}],["$","meta","29",{"name":"twitter:title","content":"Commits · fix(utility): read an odd number of hex digits as a leading zero nibble · LizardByte/Sunshine | Trylle"}],["$","meta","30",{"name":"twitter:description","content":"Commits on fix(utility): read an odd number of hex digits as a leading zero nibble (#5966) in LizardByte/Sunshine."}],["$","meta","31",{"name":"twitter:image","content":"https://trylle.com/api/og.png?kind=repo&owner=LizardByte&repo=Sunshine"}],["$","meta","32",{"name":"twitter:image:alt","content":"LizardByte/Sunshine repository preview on Trylle"}],["$","link","33",{"rel":"icon","href":"/favicon.png","type":"image/png"}],["$","link","34",{"rel":"icon","href":"/favicon-white.png","type":"image/png","media":"(prefers-color-scheme: dark)"}],"$L7b","$L7c"]

Commits on Tue, Oct 20, 2026