Description
Gentoo either uses the system libva or nothing at all, never the copy from build-deps, so check whether SUNSHINE_BUILD_VAAPI is defined before trying to use the headers.
The FFmpeg headers are copied while excluding va/ to ensure that the system libva headers are used. However, Gentoo runs Sunshine's CMake before the prepared binaries are built and installed, so the include directory won't exist yet, causing this copy to fail. Avoid this failure by checking whether va/ even exists. If headers are present but va/ is not, then there is no point in trying to exclude it.
Gentoo would need to work around this by removing the va/ directory between the FFmpeg and Sunshine builds, but there is no need because it builds FFmpeg with the system libva headers anyway.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
I have locally build tested and done a quick manual run on Gentoo.
Type of Change
- feat: New feature (non-breaking change which adds functionality)
- fix: Bug fix (non-breaking change which fixes an issue)
- docs: Documentation only changes
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
- refactor: Code change that neither fixes a bug nor adds a feature
- perf: Code change that improves performance
- test: Adding missing tests or correcting existing tests
- build: Changes that affect the build system or external dependencies
- ci: Changes to CI configuration files and scripts
- chore: Other changes that don't modify src or test files
- revert: Reverts a previous commit
- BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)
Checklist
- Code follows the style guidelines of this project
- Code has been self-reviewed
- Code has been commented, particularly in hard-to-understand areas
- Code docstring/documentation-blocks for new or existing methods/components have been added or updated
- Tests have been added or updated for new or modified functionality, including regression tests for bug fixes
AI Usage
See our AI usage policy.
- AI tools were used while preparing this PR
Activity
8
codecov[bot]2d agoBundle Report
Bundle size has no change :white_check_mark:
sonarqubecloud[bot]2d agoQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
codecov[bot]1d agoCodecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 46.15%. Comparing base (a679b05) to head (b8f7354).
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## master #6007 +/- ##
=========================================
Coverage 46.15% 46.15%
=========================================
Files 140 140
Lines 30462 30462
Branches 13114 13114
=========================================
Hits 14059 14059
+ Misses 14855 12743 -2112
- Partials 1548 3660 +2112 | Flag | Coverage Δ | |
|---|---|---|
| Alpine-aarch64 | 30.78% <ø> (+<0.01%) | :arrow_up: |
| Alpine-x86_64 | 30.90% <ø> (ø) | |
| Archlinux | 28.64% <ø> (ø) | |
| FreeBSD-amd64 | 30.53% <ø> (-0.01%) | :arrow_down: |
| Homebrew-macos-15 | 47.10% <ø> (+0.02%) | :arrow_up: |
| Homebrew-macos-26 | 47.49% <ø> (ø) | |
| Homebrew-ubuntu-24.04 | 31.51% <ø> (ø) | |
| PowerShell | 100.00% <ø> (ø) | |
| Web-UI | 56.65% <ø> (ø) | |
| Windows-AMD64 | 39.01% <ø> (ø) | |
| Windows-ARM64 | 33.27% <ø> (ø) | |
| macOS-arm64 | 38.96% <ø> (ø) | |
| macOS-x86_64 | 39.53% <ø> (+<0.01%) | :arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/config.cpp | 62.61% <ø> (ø) |
... and 48 files with indirect coverage changes
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a679b05...b8f7354. Read the comment docs.
github-actions[bot]1d ago| Last Updated | 2026-10-29 03:31:40 UTC |
| Source Run | CI Run #6472 |
| Commit | b8f7354fa086a3f8644bdc33be578c36118615a5 |
Screenshot Comparison
PR #6007 screenshots vs screenshots baseline.
Matrix: Windows-AMD64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png | ||
sunshine_tray_menu.png | ||
sunshine_tray_pairing_request.png | ||
sunshine_tray_paused.png | ||
sunshine_tray_stopped.png | ||
sunshine_tray_streaming.png | ||
sunshine_tray_tooltip.png |
Matrix: Windows-ARM64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png | ||
sunshine_tray_menu.png | ||
sunshine_tray_pairing_request.png | ||
sunshine_tray_paused.png | ||
sunshine_tray_stopped.png | ||
sunshine_tray_streaming.png | ||
sunshine_tray_tooltip.png |
Matrix: macOS-arm64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png | ||
sunshine_tray_menu.png | ||
sunshine_tray_pairing_request.png | ||
sunshine_tray_paused.png | ||
sunshine_tray_stopped.png | ||
sunshine_tray_streaming.png | ||
sunshine_tray_tooltip.png |
Matrix: macOS-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png | ||
sunshine_tray_menu.png | ||
sunshine_tray_pairing_request.png | ||
sunshine_tray_paused.png | ||
sunshine_tray_stopped.png | ||
sunshine_tray_streaming.png | ||
sunshine_tray_tooltip.png |
I approved this before I saw your other PR (https://github.com/LizardByte/Sunshine/pull/5992). I think these can be combined into one PR.