#25

chore(deps): bump rector/rector from 2.8.4 to 2.8.5

Opendependabot[bot]wants to merge intofrom

Bumps rector/rector from 2.8.4 to 2.8.5.

Release notes

Sourced from rector/rector's releases.

Released Rector 2.8.5

Bugfixes and safer reprints :bug:

This release is mostly about bugfixes - an infinite loop fix in docblock return types, kept ternary parentheses on null coalescing, more precise changed_files in JSON output, and several new skips for dead code and PHP 8.4 rules. On the extension side, PHPUnit AddDoesNotPerformAssertionToNonAssertingTestRector is now faster and more precise.

Bugfixes :bug:

  • [TypeDeclarationDocblocks] Skip invalid @return tag to fix infinite loop in DocblockReturnArrayFromDirectArrayInstanceRector (#8918)
  • [ChangesReporting] List only changed files in JSON changed_files (#8917) Thanks @​gvieira18
  • [Core] Drop file positions on reprinted nodes copied from another file (#8928)
  • Preserve ternary fallback parentheses in new coalesces (#8927) Thanks @​smotim
  • [Php70] Keep inner ternary parentheses on TernaryToNullCoalescingRector (#8921)
  • [Php55] Handle variable interpolated in pattern on PregReplaceEModifierRector (#8922)
  • [Php84] Skip variable modified in condition on ForeachToArrayAllRector, ForeachToArrayAnyRector, ForeachToArrayFindRector and ForeachToArrayFindKeyRector (#8925)
  • [DeadCode] Skip conditional return type on RemoveUselessReturnTagRector (#8924) Thanks @​APX403
  • [DeadCode] Skip private methods used as callables on RemoveUnusedPrivateMethodParameterRector (#8923) Thanks @​phinor
  • [CodingStyle] Skip closure with rebound $this on ArrowFunctionDelegatingCallToFirstClassCallableRector and ClosureDelegatingCallToFirstClassCallableRector (#8931)

Performance Improvements :rocket:

  • Remove usage of CloningVisitor on AstResolver (#8861)

Internals :gear:

  • [Printer] Remove unneeded BetterStandardPrinter::pStmt_FileNode() (#8904)
  • [CodingStyle] Cover Doctrine/Symfony aliased names on import names with real stubs (#8932, #8933)

rector-symfony :musical_note:

  • [Symfony61] Do not add #[AsCommand] without a name in CommandConfigureToAttributeRector (#1102) Thanks @​kix
  • Skip first-class callable in CommandConfigureToAttributeRector (#1104)

rector-phpunit :green_circle:

  • [PHPUnit90] Handle named and unpacked preg_match() args and skip non-literal expected value in AssertRegExpRector (#820, #819) Thanks @​alies-dev
  • [PHPUnit100] Add willReturnOnConsecutiveCalls() variables to closure use() in WithConsecutiveRector (#821)
  • [PHPUnit120] Skip mocks configured through an alias in ExpressionCreateMockToCreateStubRector (#823) Thanks @​bbrala
  • [PHPUnit60] Follow parent::test() calls in AddDoesNotPerformAssertionToNonAssertingTestRector (#826) Thanks @​bbrala
  • [PHPUnit60] Count expectUserDeprecationMessage() as assert, skip test methods in abstract classes and skip tests in classes with own asserting lifecycle methods in AddDoesNotPerformAssertionToNonAssertingTestRector (#825, #828, #831)
  • [PHPUnit60] Speed up AddDoesNotPerformAssertionToNonAssertingTestRector - change node to Class_, cache containsAssertCall() per node and never parse PHPUnit and Symfony base test case methods (#830, #829, #833, #824)

... (truncated)

Commits
  • bf2982e Rector 2.8.5
  • f1bb9a1 Updated Rector to commit 9f30de4a6caa13615f9e4d20bbe5282aac528575
  • 55f2cda Updated Rector to commit 9f30de4a6caa13615f9e4d20bbe5282aac528575
  • ed28610 Updated Rector to commit 9f30de4a6caa13615f9e4d20bbe5282aac528575
  • a6f5c21 Updated Rector to commit 8dd83d8721a47df944c207778189daf6e5711a8e
  • b5e9d1b Updated Rector to commit a1fbcf3b97457ef3b2fcad3d50ccb26379991079
  • 57c53a5 Updated Rector to commit a1fbcf3b97457ef3b2fcad3d50ccb26379991079
  • e47aa88 Updated Rector to commit a1fbcf3b97457ef3b2fcad3d50ccb26379991079
  • 68cbe74 Updated Rector to commit a1fbcf3b97457ef3b2fcad3d50ccb26379991079
  • 7ebfece Updated Rector to commit a1fbcf3b97457ef3b2fcad3d50ccb26379991079
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

This change is 


Summary by cubic

Updates rector/rector from 2.8.4 to 2.8.5, a patch release of bugfixes and safer reprints. phpstan/phpstan also moves from 2.3.5 to 2.3.6 via the same update.

Notes

  • Removes published-time entries and drops plugin-api-version to 2.9.0 in composer.lock; the lock file was refreshed with an older Composer version.
  • 2.8.5 fixes an infinite loop in docblock return types, preserves ternary parentheses on null coalescing, and adds several skips for dead code and PHP 8.4 rules.

Written for commit ed53cd45f88cb97db7e5e88217a3cda4a24a603a. Summary will update on new commits.

Activity

8
dependabot[bot]3d ago

Labels

The following labels could not be found: php. Please create it before Dependabot can add it to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

aviator-app[bot]3d ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.
greptile-apps[bot]3d ago

PR author is in the excluded authors list.

snyk-io[bot]3d ago

:white_check_mark: Snyk checks have passed. No issues have been found so far.

StatusScan Engine Critical High Medium LowTotal (0)
:white_check_mark:Open Source Security0000 0 issues

:computer: Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

mergify[bot]1d ago

Tick the box to add this pull request to the merge queue (same as @mergifyio queue). If it does not match the queue conditions yet, it enters the queue once it does.

  • Queue this pull request once it meets the queue conditions
codacy-production[bot]1d ago

Up to standards :white_check_mark:

🟢 Issues 0 issues

Results: 0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

MetricResults
Complexity0
Duplication0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.