This is a merge queue draft opened by Mergify. Its pull request has merged, and nobody needs to act on it.
Mergify opened it for batch petite-persillade-w89wpt of the default queue, to test #94 before it merged into main.
🎉 What landed
Mergify merged its pull request into main, then closed this draft:
#94 feat: allow a local production image without GHCR (ashcoft), as 9b3fad4
### Issue 1
readme.md:299
The backup command parses `.env` differently from Compose. For example, `POL_VERSION="1.4.0"` works in Compose, but this command keeps the quote characters, so `docker save` receives an invalid image name. It also overwrites any exported `POL_VERSION`, which can select a different image from the one Compose uses.
Ask Compose for the resolved application image instead. Apply the same fix to the repeated backup command in Operations.
### Issue 2
readme.md:300-301
If `docker save` fails because the image is missing or Docker is unavailable, `gzip` can still accept the empty input, write an empty compressed archive, and report success. The command can also overwrite an earlier usable backup.
Enable `pipefail` and replace the backup only after the whole pipeline succeeds. Fix the repeated Operations example too.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary
The PR lets production use a locally built or restored application image.
Production can run a local image under the shared version tag.
Make development builds use the configured production image tag and let production choose whether to pull it, enabling local-image reuse.
docker-compose.prod.yml L6
docker-compose.yaml L3
Exclude image archives from the Docker build context so saved image backups are not copied into builds.
.dockerignore L16
Documentation
Document the configurable pull policy and the workflow for building, backing up, restoring, and running a local production image.
readme.md L282-313, L346, L404-410
Tips and commands
Interacting with Sourcery
Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
admin changed the title from merge queue: checking #94 on main (0d35f7a) to merge queue: merged #94: feat: allow a local production image without GHCR2h ago
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewerTIP This summary will be updated as you push new changes.
greptile-apps[bot]reviewed2h ago
greptile-apps[bot]reviewed2h ago
greptile-apps[bot]reviewed2h ago
This pull request was closed without being merged. Branch mergify/merge-queue/c957554c97 is still available.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Share