#96

merge queue: merged #94: feat: allow a local production image without GHCR

NOTE

This is a merge queue draft opened by Mergify. Its pull request has merged, and nobody needs to act on it. Mergify opened it for batch petite-persillade-w89wpt of the default queue, to test #94 before it merged into main.

🎉 What landed

Mergify merged its pull request into main, then closed this draft:

  • #94 feat: allow a local production image without GHCR (ashcoft), as 9b3fad4

This draft's code was built in this order:

  1. main at 0d35f7a
  2. #94, the pull request of this batch
Metadata for CI tooling, read by mergify ci
---
all_scopes: false
checking_base_sha: 0d35f7a7d748991f3b3ec276965d6ddf6aebf3a2
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 94
    scopes: []
queue_base_sha: 0d35f7a7d748991f3b3ec276965d6ddf6aebf3a2
scopes: []
...
Required conditions of queue rule default for merge

No extra conditions.

Required conditions to stay in the queue

None


Summary by cubic

Lets production Docker deployments use a locally built image instead of always pulling from GHCR, which helps hosts that cannot reach the registry.

  • Makes the production pull policy configurable with POL_PULL_POLICY (default always; set never for a locally built image).
  • Unifies the image tag across both compose files via POL_VERSION so local builds carry the tag production expects.
  • Documents a docker save/load backup workflow so a removed container does not force a GHCR login.
  • Excludes image archive backups from the Docker build context and updates .env.example.

Written for commit cca6d240a8e3808f99719850f04f826a8fcf881e. Summary will update on new commits.

Confidence Score: 4/5

The PR appears safe to merge, with non-blocking fixes recommended for the image-backup instructions.

Findings

  1.  Backup chooses the wrong image ▶
  2.  Failed backup looks successful ▶
Fix with agent prompt
### Issue 1
readme.md:299
The backup command parses `.env` differently from Compose. For example, `POL_VERSION="1.4.0"` works in Compose, but this command keeps the quote characters, so `docker save` receives an invalid image name. It also overwrites any exported `POL_VERSION`, which can select a different image from the one Compose uses.

Ask Compose for the resolved application image instead. Apply the same fix to the repeated backup command in Operations.

### Issue 2
readme.md:300-301
If `docker save` fails because the image is missing or Docker is unavailable, `gzip` can still accept the empty input, write an empty compressed archive, and report success. The command can also overwrite an earlier usable backup.

Enable `pipefail` and replace the backup only after the whole pipeline succeeds. Fix the repeated Operations example too.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR lets production use a locally built or restored application image.

  • Production can run a local image under the shared version tag.

Reviews (1) · Last reviewed commit: "Merge of PR 94" · Reviewed by Greptile

Activity

16
S
f14fec4
M
cca6d24
coderabbitai[bot]2h ago

IMPORTANT

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4ccfc31b-4579-4b61-bd74-ccbb70e8609b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

snyk-io[bot]2h ago

:white_check_mark: Snyk checks have passed. No issues have been found so far.

StatusScan Engine Critical High Medium LowTotal (0)
:white_check_mark:Open Source Security0000 0 issues

:computer: Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

sourcery-ai[bot]2h ago

Reviewer's Guide

Configuration

Make development builds use the configured production image tag and let production choose whether to pull it, enabling local-image reuse.

  • docker-compose.prod.yml L6
  • docker-compose.yaml L3

Exclude image archives from the Docker build context so saved image backups are not copied into builds.

  • .dockerignore L16

Documentation

Document the configurable pull policy and the workflow for building, backing up, restoring, and running a local production image.

  • readme.md L282-313, L346, L404-410

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

admin changed the title from merge queue: checking #94 on main (0d35f7a) to merge queue: merged #94: feat: allow a local production image without GHCR2h ago
admin closed this pull request2h ago
codacy-production[bot]2h ago

Up to standards :white_check_mark:

🟢 Issues 0 issues

Results: 0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

MetricResults
Complexity0
Duplication0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.

greptile-apps[bot]reviewed2h ago
greptile-apps[bot]reviewed2h ago
greptile-apps[bot]reviewed2h ago

This pull request was closed without being merged. Branch mergify/merge-queue/c957554c97 is still available.