#97

merge queue: merged #95: Fix the Rails template leftover and sanitize preview links

NOTE

This is a merge queue draft opened by Mergify. Its pull request has merged, and nobody needs to act on it. Mergify opened it for batch nearest-betterave-hvx3mj of the default queue, to test #95 before it merged into main.

🎉 What landed

Mergify merged its pull request into main, then closed this draft:

  • #95 Fix the Rails template leftover and sanitize preview links (ashcoft), as 187e509

This draft's code was built in this order:

  1. main at b8a34d0
  2. #95, the pull request of this batch
Metadata for CI tooling, read by mergify ci
---
all_scopes: false
checking_base_sha: b8a34d093170f1a803eb1299b11ed2d38c5b155a
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 95
    scopes: []
queue_base_sha: b8a34d093170f1a803eb1299b11ed2d38c5b155a
scopes: []
...
Required conditions of queue rule default for merge

No extra conditions.

Required conditions to stay in the queue

None

Confidence Score: 5/5

This PR appears safe to merge.

Summary

This PR makes feed previews safer and removes leftover Rails markup from the shared page.

  • Feed previews show titles and descriptions as text, with only web links clickable.
  • Shared pages use Django's sign-in check and a full-width content area.

No actionable issues were found.

Reviews (1) · Last reviewed commit: "Merge of PR 95" · Reviewed by Greptile

Activity

15
S
b8a34d0
M
2f501f3
coderabbitai[bot]2h ago

IMPORTANT

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ddd38b35-8999-4cb4-802b-160b135398fb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

snyk-io[bot]2h ago

:white_check_mark: Snyk checks have passed. No issues have been found so far.

StatusScan Engine Critical High Medium LowTotal (0)
:white_check_mark:Open Source Security0000 0 issues

:computer: Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

admin changed the title from merge queue: checking #95 on main (b8a34d0) to merge queue: merged #95: Fix the Rails template leftover and sanitize preview links2h ago
sourcery-ai[bot]2h ago

Reviewer's Guide

Implementation

Extract preview item normalization and rendering into a reusable module, allowing only HTTP(S) links and treating feed content as text.

  • frontend/frontend/assets/frontend/js/preview.js L1-65

UI

Replace leftover Rails template markup and use Django authentication state in the shared page layout.

  • frontend/frontend/templates/base.html L77-80

Load the preview renderer and replace the template’s unsafe inline item rendering with the module call.

  • frontend/frontend/templates/frontend/preview.html L30, L39

Tests

Add Node tests for URL filtering and safe preview title and description rendering.

  • tests/js/preview.test.js L1-82

Add Django regression tests for the repaired template markup and preview renderer integration.

  • tests/test_reader_django.py L85-102

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

admin closed this pull request2h ago
codacy-production[bot]2h ago

Up to standards :white_check_mark:

🟢 Issues 0 issues

Results: 0 new issues

View in Codacy

🟢 Metrics 19 complexity · 0 duplication

MetricResults
Complexity19
Duplication0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.

This pull request was closed without being merged. Branch mergify/merge-queue/fa18114a5a is still available.