- Add handler to remove dns record entry with given name
- Another handler to remove specific record entry for given name and record
- Update client to use that api endpoints to have end to end test
Assisted-by: Cursor
Activity
12
openshift-ci[bot]8mo ago[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: praveenkumar Once this PR has been reviewed and has the lgtm label, please assign evidolob for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
openshift-ci[bot]8mo ago[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: praveenkumar Once this PR has been reviewed and has the lgtm label, please assign evidolob for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
openshift-ci[bot]8mo ago[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: praveenkumar Once this PR has been reviewed and has the lgtm label, please assign evidolob for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
openshift-ci[bot]8mo ago[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: praveenkumar Once this PR has been reviewed and has the lgtm label, please assign evidolob for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
openshift-ci[bot]8mo ago[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: praveenkumar Once this PR has been reviewed and has the lgtm label, please assign evidolob for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
openshift-ci[bot]2mo agoPR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
cfergeau1mo agoI’ve addressed the remaining comments, and fixed a few other things on the way (or rather claude did it) in https://github.com/cfergeau/gvisor-tap-vsock/tree/dns_remove. This should be good to go after a review of the new code.
cfergeau1mo agoI’ve addressed the remaining comments, and fixed a few other things on the way (or rather claude did it) in https://github.com/cfergeau/gvisor-tap-vsock/tree/dns_remove. This should be good to go after a review of the new code.
I’ve added a few more commits to this branch https://github.com/cfergeau/gvisor-tap-vsock/tree/dns_remove, and reviewed them again, imo we can go with this, most of them can be squashed in the initial commit unless we want to keep some history.
praveenkumar22d agoI’ve addressed the remaining comments, and fixed a few other things on the way (or rather claude did it) in https://github.com/cfergeau/gvisor-tap-vsock/tree/dns_remove. This should be good to go after a review of the new code.
I’ve added a few more commits to this branch https://github.com/cfergeau/gvisor-tap-vsock/tree/dns_remove, and reviewed them again, imo we can go with this, most of them can be squashed in the initial commit unless we want to keep some history.
@cfergeau you can go with that once some of the commits squashed to initial one.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: praveenkumar Once this PR has been reviewed and has the lgtm label, please assign evidolob for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing
/approvein a comment Approvers can cancel approval by writing/approve cancelin a comment