#760
Pull Requests/containers/gvisor-tap-vsock/#760

Bug fixes/refactor for the gvproxy/win-sshproxy code creating ssh socket forwards

Opencfergeauwants to merge intofrom
8 commits8 files changed+555-105

This PR starts with some refactoring to share the code creating ssh forward sockets between gvproxy and win-sshproxy. Then it fixes a few leaks in error cases, and what can arguably be seen as a regression in 0.9.0 (it’s at least a behaviour change): the unix sockets listed on the command line are no longer removed before trying to call Listen.

Activity

10
C
gvproxy: extract setupForwards() from run()
5442057
C
win-sshproxy: make setupProxies match gvproxy setupForwards
6622992
C
sshclient: share forward setup between gvproxy and win-sshproxy
35a82b7
C
sshclient: fix socket cleanup in SetupForwards
e73b8ea
C
sshclient: remove stale unix socket files in SetupForwards
79ef9d0
C
sshclient: close listener when SSH setup fails
ef24b55
C
sshclient: close bastion connection when its setup fails
834145f
C
ci: run sshclient unit tests on Windows
f9acf51
evidolobapproved changes16h ago
openshift-ci[bot]16h ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, evidolob

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment