#1
fix: hardening — NULL check, max_inode bound, stopAccessing leak
Summary
3 hardening fixes from W0lfSword deep audit.
Changes
- bad_query.c:150 — Add NULL guard on
pathparameter inbad_query_list()(prevent crash) - bad_query.c:150 — Clamp
max_inodeto UINT32_MAX to prevent infinite loop if caller passes INT64_MAX - ContentView.swift:111 — Add
stopAccessingSecurityScopedResource()viadefer(was leaking kernel security-scoped resource handle)
Testing
- Compiles with Xcode
-
bad_query_list(NULL, 0)returns NULL instead of crashing -
bad_query_list(path, INT64_MAX)does not hang
Activity
10sousickyapproved changes3mo ago
@forcequitOS I have compile this source and run success. Is there any chance not ask open develp mode?
Some of these will likely be resolved in a future revision (without 100% vibe-reviewing the code to find things I should fix), thanks I guess, though.
I'll close this PR when I get around to updating this repo
Alright!(sorry for sloppifying everything with deepseek i didnt even know it made a PR😭😭)
hi
hi
hi
sousickyapproved changes2mo ago
sousickyapproved changes2mo ago
sousickyapproved changes1mo ago
Some of these will likely be resolved in a future revision (without 100% vibe-reviewing the code to find things I should fix), thanks I guess, though. I'll close this PR when I get around to updating this repo