#1289
Pull Requests/foyer-rs/foyer/#1289

fix: Short-circuit fetch on insert

Opensfc-gh-rnarubinwants to merge intofrom
1 commit2 files changed+67-2

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

There was a bug in the inflight tracking where the close boolean was duplicated instead of cloned. This could result in fetch futures running in the background even though all the waiters were already resolved.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed cargo x (or cargo x --fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

Activity

2
R
fix: Short-circuit fetch on insert
9e81479
codecov[bot]6mo ago

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

:exclamation: There is a different number of reports uploaded between BASE (481c3de) and HEAD (9e81479). Click for more details.

HEAD has 2 uploads less than BASE
FlagBASE (481c3de)HEAD (9e81479)
31
Files with missing linesCoverage Δ
foyer-memory/src/inflight.rs62.80% <100.00%> (-27.28%):arrow_down:
foyer-memory/src/raw.rs49.42% <ø> (-37.98%):arrow_down:

... and 52 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.