79:T818, ## Summary - `ClaudeCodeBackend` now captures child PIDs after connecting and kills them explicitly in `disconnect()` and via `atexit`, so the `claude` CLI subprocess is cleaned up on any exit path - `tui.py` `on_unmount` now calls `controller.stop()` so the controller's disconnect path actually runs when the TUI closes - `main.py` installs a SIGTERM handler so `docker stop` triggers `sys.exit()` and therefore `atexit` cleanup ## Root cause When the Python controller exited (TUI closed, Ctrl+C, or `docker stop`), the `claude` CLI subprocess it spawned was orphaned — re-parented to the container's bash (PID 1) — and kept running indefinitely. The controller's `stop()` method only set an in-memory flag, which does nothing if the Python process is already gone. ## Test plan - [ ] All existing tests pass (`make test`) - [ ] Start a session, quit via Ctrl+Q — verify no `claude` process remains (`ps aux`) - [ ] Start a session, run `docker stop pentestgpt` — verify process is gone on restart - [ ] Start a session, kill the Python process directly — verify subprocess is cleaned up via `atexit` 7a:T1581,## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where `claude` CLI subprocesses were being orphaned and left running indefinitely after the main Python controller process exited. The changes ensure that these subprocesses are properly terminated across various exit paths, including TUI closure, Ctrl+C, and `docker stop`, by implementing explicit child process tracking and cleanup mechanisms. ### Highlights * **Subprocess Management**: The `ClaudeCodeBackend` now actively tracks and terminates its child `claude` CLI subprocesses upon disconnection or application exit, preventing orphaned processes. * **TUI Cleanup Integration**: The TUI's `on_unmount` method was updated to ensure the controller's disconnect logic, including subprocess termination, is properly triggered when the TUI closes. * **Docker Stop Handling**: A SIGTERM handler has been implemented in `main.py` to gracefully shut down the application and trigger `atexit` cleanup when a `docker stop` command is issued. 🧠 **New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**

Changelog

* **pentestgpt/core/backend.py** * Added `atexit`, `os`, and `signal` imports for process management. * Implemented a new `_get_child_pids` function to identify direct child processes on Linux. * Introduced a `_subprocess_pids` attribute to `ClaudeCodeBackend` to track spawned subprocesses. * Created a `_kill_subprocesses` method to terminate all tracked PIDs. * Registered `_kill_subprocesses` with `atexit` for automatic cleanup upon program exit. * Modified the `connect` method to capture and track new child PIDs after establishing a connection. * Called `_kill_subprocesses` within the `disconnect` method to ensure termination on explicit disconnection. * Updated the `resume` method to also capture and track new child PIDs. * **pentestgpt/interface/main.py** * Imported the `signal` module. * Added a SIGTERM handler in the `main()` function to ensure `sys.exit()` is called, which triggers `atexit` cleanup, when the process receives a SIGTERM signal (e.g., from `docker stop`). * **pentestgpt/interface/tui.py** * Modified the `on_unmount` method to call `self._controller.stop()`, ensuring proper disconnection and subprocess termination when the TUI application closes. * Increased the `_agent_thread.join()` timeout from 2.0 to 5.0 seconds to allow more time for the agent thread to finish gracefully.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either `/gemini ` or `@gemini-code-assist `. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).

[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). 63:["$","$L76",null,{"entries":[{"key":["platform",{"userId":"anon"},"pulls","page",{"owner":"greydgl","repo":"PentestGPT","pullNumber":430}],"data":{"repositoryId":"5405","detail":{"author":{"avatarUrl":"https://cdn.trylle.com/media/images/376ea9380e2b50f3f4efeb0f47330a17?key=ARqDWZVB6wxnZC73dXjM6sM4tt6nXVP2G4nCBPBdFChkf5XcHQLOQqaLrl3A89oz%2FSkduX8dvyTtAFi6R1UVcgzGc6HWZoch3cWwRS%2F%2FTFiBE2zTNyagQNDViu04pboYePsRDA9vRu43zO6dbyfqUdXgrDd81I3s9VIqX4SikMNaBEhhpYPI3e11fw%3D%3D","externalProvider":"github","login":"aholston","type":"User","url":"https://github.com/aholston"},"authorId":"30006852","baseRefName":"main","closedAt":null,"comments":2,"createdAt":"2026-03-17T14:13:24Z","headRefName":"aholston/fix/subprocess-cleanup","id":"4967112","isDraft":false,"labels":[],"number":430,"repository":{"name":"PentestGPT","owner":"greydgl","provider":"forgejo"},"state":"open","title":"fix: kill Claude subprocess on stop/exit to prevent orphaned agents","updatedAt":"2026-03-17T14:17:55Z","url":"https://trylle.com/GreyDGL/PentestGPT/pulls/430","body":"$79","additions":76,"deletions":57,"changedFiles":3,"commits":2,"reviewComments":1,"headSha":"afc4898724b4b1702210f628a9c75b6d7fb7f1f6","baseSha":"e8b1bb77d1ac00329675cec3b060aba971ec1ac8","headRepoOwner":"GreyDGL","headRepoName":"PentestGPT","isMerged":false,"mergeCommitSha":null,"mergedBy":null,"mergeable":false,"mergeableState":"dirty","conflictingFiles":["pentestgpt/core/backend.py","pentestgpt/interface/main.py","pentestgpt/interface/tui.py"],"requestedTeams":[],"requestedReviewers":[],"graphqlId":"issue:430","reactions":{"counts":{"eyes":1},"viewerReacted":null,"userLoginsByContent":{"eyes":["gemini-code-assist[bot](github)"]}}},"comments":[{"id":27071541,"graphqlId":"27071541","body":"$7a","createdAt":"2026-03-17T14:13:43Z","author":{"avatarUrl":"https://cdn.trylle.com/media/images/8bd0fbbef6fea78538312b8572e70b1e?key=AR3O86QNRCDVB0aEG8cVMxYeGMsCJrwDQK4DdGTWWvoupmPwGuD%2BTcXmrV1TWAaUabaeWU%2FRFWZoAw1EvTjy2ImG3HYVg7y3GnFXP7CW054kOvkKlq6OTK43ZSJKua5kAjuaMBEKVFjmID5JneH9sGCaG1rKTra%2BVy7bXdH700LewMbSFSoj4fOEdVs%3D","externalProvider":"github","login":"gemini-code-assist[bot]","type":"Bot","url":"https://github.com/apps/gemini-code-assist"}}],"commits":[{"sha":"afc4898724b4b1702210f628a9c75b6d7fb7f1f6","message":"remove code duplication between connect() and resume()\n","createdAt":"2026-03-17T09:17:41-05:00","author":{"avatarUrl":"","login":"","name":"Andre Holston","type":"User","url":""},"verification":{"verified":false,"reason":"gpg.error.not_signed_commit"}},{"sha":"fbb8cc4a7e88d07b2d20db6017f542a6940571eb","message":"kill Claude subprocess on stop/exit to prevent orphaned agents\n","createdAt":"2026-03-17T09:10:33-05:00","author":{"avatarUrl":"","login":"","name":"Andre Holston","type":"User","url":""},"verification":{"verified":false,"reason":"gpg.error.not_signed_commit"}}],"events":[{"id":27070727,"event":"reviewed","createdAt":"2026-03-17T14:14:36Z","actor":{"avatarUrl":"https://cdn.trylle.com/media/images/8bd0fbbef6fea78538312b8572e70b1e?key=AR3O86QNRCDVB0aEG8cVMxYeGMsCJrwDQK4DdGTWWvoupmPwGuD%2BTcXmrV1TWAaUabaeWU%2FRFWZoAw1EvTjy2ImG3HYVg7y3GnFXP7CW054kOvkKlq6OTK43ZSJKua5kAjuaMBEKVFjmID5JneH9sGCaG1rKTra%2BVy7bXdH700LewMbSFSoj4fOEdVs%3D","externalProvider":"github","login":"gemini-code-assist[bot]","type":"Bot","url":"https://github.com/apps/gemini-code-assist"},"reviewId":3650565,"reviewState":"COMMENT","body":"## Code Review\n\nThis pull request effectively addresses the issue of orphaned `claude` subprocesses by implementing cleanup logic on exit, stop, and disconnect paths. The use of `atexit`, a `SIGTERM` handler for Docker, and explicit cleanup in the TUI unmount process are all solid improvements. My main feedback is a suggestion to refactor some duplicated code in `pentestgpt/core/backend.py` to improve maintainability."}],"reviews":[{"id":3650565,"state":"COMMENT","author":{"avatarUrl":"https://cdn.trylle.com/media/images/8bd0fbbef6fea78538312b8572e70b1e?key=AR3O86QNRCDVB0aEG8cVMxYeGMsCJrwDQK4DdGTWWvoupmPwGuD%2BTcXmrV1TWAaUabaeWU%2FRFWZoAw1EvTjy2ImG3HYVg7y3GnFXP7CW054kOvkKlq6OTK43ZSJKua5kAjuaMBEKVFjmID5JneH9sGCaG1rKTra%2BVy7bXdH700LewMbSFSoj4fOEdVs%3D","externalProvider":"github","login":"gemini-code-assist[bot]","type":"Bot","url":"https://github.com/apps/gemini-code-assist"},"body":"## Code Review\n\nThis pull request effectively addresses the issue of orphaned `claude` subprocesses by implementing cleanup logic on exit, stop, and disconnect paths. The use of `atexit`, a `SIGTERM` handler for Docker, and explicit cleanup in the TUI unmount process are all solid improvements. My main feedback is a suggestion to refactor some duplicated code in `pentestgpt/core/backend.py` to improve maintainability.","submittedAt":"2026-03-17T14:14:36Z","official":false}],"stackEvents":[],"commentPagination":{"totalCount":2,"perPage":30,"loadedPages":[1]},"eventPagination":{"loadedPages":[1],"hasMore":false},"headRefDeleted":false},"fetchedAt":1794164033681}],"children":"$L7b"}] 65:null 6c:[["$","title","0",{"children":"Commits · fix: kill Claude subprocess on stop/exit to prevent orphaned agents · greydgl/PentestGPT | Trylle"}],["$","meta","1",{"name":"description","content":"Commits on fix: kill Claude subprocess on stop/exit to prevent orphaned agents (#430) in greydgl/PentestGPT."}],["$","meta","2",{"name":"application-name","content":"Trylle"}],["$","link","3",{"rel":"manifest","href":"/manifest.json","crossOrigin":"$undefined"}],["$","meta","4",{"name":"keywords","content":"Commits · fix: kill Claude subprocess on stop/exit to prevent orphaned agents · greydgl/PentestGPT, GreyDGL/PentestGPT, GreyDGL/PentestGPT repository, PentestGPT, Python repository, source code, trylle, agent-native git platform, git platform for agents and humans, git platform for ai agents, coding agent pull requests, ai code review, repository automation, stacked pull requests, two-way github sync, github-compatible actions, try cli"}],["$","meta","5",{"name":"robots","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","6",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","7",{"name":"googlebot","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","8",{"name":"twitter:domain","content":"trylle.com"}],["$","meta","9",{"name":"twitter:url","content":"https://trylle.com/greydgl/PentestGPT/pulls/430/commits"}],["$","link","10",{"rel":"canonical","href":"https://trylle.com/greydgl/PentestGPT/pulls/430/commits"}],["$","meta","11",{"name":"format-detection","content":"telephone=no"}],["$","meta","12",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","13",{"name":"apple-mobile-web-app-title","content":"Trylle"}],["$","meta","14",{"name":"apple-mobile-web-app-status-bar-style","content":"black-translucent"}],["$","meta","15",{"property":"og:title","content":"Commits · fix: kill Claude subprocess on stop/exit to prevent orphaned agents · greydgl/PentestGPT | Trylle"}],["$","meta","16",{"property":"og:description","content":"Commits on fix: kill Claude subprocess on stop/exit to prevent orphaned agents (#430) in greydgl/PentestGPT."}],["$","meta","17",{"property":"og:url","content":"https://trylle.com/greydgl/PentestGPT/pulls/430/commits"}],["$","meta","18",{"property":"og:site_name","content":"Trylle"}],["$","meta","19",{"property":"og:locale","content":"en_US"}],["$","meta","20",{"property":"og:image","content":"https://trylle.com/api/og.png?kind=repo&owner=GreyDGL&repo=PentestGPT"}],["$","meta","21",{"property":"og:image:secure_url","content":"https://trylle.com/api/og.png?kind=repo&owner=GreyDGL&repo=PentestGPT"}],["$","meta","22",{"property":"og:image:type","content":"image/png"}],["$","meta","23",{"property":"og:image:width","content":"1200"}],["$","meta","24",{"property":"og:image:height","content":"630"}],["$","meta","25",{"property":"og:image:alt","content":"GreyDGL/PentestGPT repository preview on Trylle"}],["$","meta","26",{"property":"og:type","content":"website"}],["$","meta","27",{"name":"twitter:card","content":"summary_large_image"}],["$","meta","28",{"name":"twitter:site","content":"@trylle"}],["$","meta","29",{"name":"twitter:title","content":"Commits · fix: kill Claude subprocess on stop/exit to prevent orphaned agents · greydgl/PentestGPT | Trylle"}],["$","meta","30",{"name":"twitter:description","content":"Commits on fix: kill Claude subprocess on stop/exit to prevent orphaned agents (#430) in greydgl/PentestGPT."}],["$","meta","31",{"name":"twitter:image","content":"https://trylle.com/api/og.png?kind=repo&owner=GreyDGL&repo=PentestGPT"}],["$","meta","32",{"name":"twitter:image:alt","content":"GreyDGL/PentestGPT repository preview on Trylle"}],["$","link","33",{"rel":"icon","href":"/favicon.png","type":"image/png"}],["$","link","34",{"rel":"icon","href":"/favicon-white.png","type":"image/png","media":"(prefers-color-scheme: dark)"}],["$","link","35",{"rel":"apple-touch-icon","href":"/logo192.png"}],"$L7c"]

Commits on Tue, Mar 17, 2026