#2774
Issues/imputnet/helium/#2774

[Bug]: Vertical tab gray color

OpenGeHixgodopened 8d ago

Version

0.20.1.1

Have you tested that this is not an upstream issue or an issue with your configuration?

  • I have tried reproducing this issue in Chrome and it could not be reproduced there
  • I have tried reproducing this issue in ungoogled-chromium and it could not be reproduced there
  • I have tried reproducing this issue in Helium with a new and empty profile using --user-data-dir command line argument and it could not be reproduced there

Description

When I open a separate login window using Google on Reddit, the vertical tab turns gray for a few seconds instead of black.

How to Reproduce?

When you try to log in to Reddit, for example, using your Google account, a separate window opens after you click this button, and during the entire process, the vertical tab bar turns gray.

I'm using my own custom theme, which features very dark colors throughout Helium. And until that login window closes, the panel's color does not change back to black.

First photo: before the entrance window was opened.

Second photo: while the entrance window was open.

This error probably first appeared in version 0.18 or 0.19.

Actual behavior

When you try to log in to Reddit, for example, using your Google account, a separate window opens after you click this button, and during the entire process, the vertical tab bar turns gray.

Expected behavior

The background must remain black in any case.

Additional context

[No response]

https://github.com/user-attachments/assets/d4127463-433e-4b9c-b89b-4c8c9bec3553

Activity

3
bananakid8d ago

Cannot reproduce in Windows.

GeHixgod8d ago

4. Cannot reproduce in Windows.

Maybe it's because I created my own theme.

git-aarvin6d ago

This probably has to do with respecting frame_inactive:

{
	"manifest_version": 3,
	"name": "Theme",
	"version": "1.0",
	"theme": {
		"colors": {
			"frame": [40, 40, 40,],
			"frame_inactive": [70, 70, 70,],
		},
	},
}

It's also possible the custom theme doesn't define this, which would explain the gray. Even so, Helium could maybe default to using the normal frame color when frame_inactive isn't defined rather than gray.