#799

CI & DevEx: eliminate path-filter blind spots, enforce strict workflow linting, and align local tooling

OpensombraSoftopened 10h ago

Follow-up to #418 addressing four gaps left after the first CI round:

  1. Path-filter & test-discovery blind spots: .github/workflows/runtime.yml currently uses a paths: allow-list, so adding a new vendored C++ library under third_party/ or helper under scripts/ silently skips Runtime. Meanwhile ci.yml only globs top-level tests/test_*.py and hardcodes tests/test_viewer_streaming.cjs, so tests added in new subdirectories or .cjs files would be skipped silently. Also aligns concurrency (PR-only cancellation + unique non-PR groups matching 78e6c90) across runtime.yml, no-game-data.yml, and jactionlint.yml.
  2. Strict workflow & Dependabot hygiene: All workflows now declare timeout-minutes and concurrency, leaving only 3 jactionlint --profile default findings (runtime.yml pipeline without pipefail + missing 7-day cooldowns in dependabot.yml). Fixing those lets us promote jactionlint.yml to profile: default and add weekly grouped pip (tests/requirements.txt) and nuget (tools/rpf9dump, tests/Rpf9DumpDiagnostics) Dependabot updates.
  3. CI / local runtime alignment: Share runtime/CMakePresets.json (windows-ninja, linux-ninja) between runtime.yml and scripts/build_runtime.ps1 (plus -Test switch) so local builds use the same Ninja + LEONIDA_D3D12_SHIM_TESTS=ON flags as CI without requiring sccache, and align runtime.yml's linux-gpu-tools job from llvm-18 to llvm-21 to match ci.yml and docs/testing.md.
  4. Single-command local verification: Add stdlib-only scripts/run_checks.py (with unit tests) mirroring CI's checks locally, and update CONTRIBUTING.md to document tests/requirements.txt, Rpf9DumpDiagnostics, header-only Vulkan-Headers, and jactionlint.

Consequences & trade-offs

  • Switching runtime.yml to paths-ignore: means future unknown directories run Runtime by default (safe-by-default) while still skipping docs, tests, viewer, and assets PRs.
  • dependabot.yml adds weekly grouped pip and nuget PRs capped at open-pull-requests-limit: 1 with a 7-day release cooldown.
  • docs/testing.md is intentionally left untouched in this batch.

PRs

  • #800 — CI: use deny-list path filtering in Runtime and generalize test discovery (base: main)
  • #801 — CI: promote jactionlint to default profile and add Dependabot cooldowns and pip/NuGet updates (depends on #800)
  • #802 — CI: share runtime CMakePresets across local/CI builds and upgrade Runtime Linux job to LLVM 21 (depends on #801)
  • #803 — DevEx: add local CI check runner script and update contributor guide (independent, base: main)

Activity

0

No activity yet.