Hey 👋
Thanks for this initiative! 💪
Would be nice to also configure auto-close of pull requests from non-collaborators that either have no bound GitHub issue/s or the issues are not assigned to the pull request submitter's account.
I want to first review an issue, greenlight and assign it manually to a specific vouched account.
I want to avoid 2 or more vouched accounts submitting competing pull requests for the same issue. I want visibility on who is working on what. I want to delay work on certain parts of the system to avoid conflicts when necessary.
Activity
18
DitherDude8mo agoI have no control what-so-ever over this project in any way, but I'm a little bit confused over your post (don'b blame yourself I'm also tired). So to clarify:
- user creates PR.
- if (you are collaborator) -> skip/ignore/allow PR
- otherwise if (PR does not have corrsponding issue) OR (PR author is not assigned
anto said corresponding issue) -> close PR - otherwise wait for admin to delegate to another account/contributor?
And then I don't understand how your final paragraph relates to vouch as a project...
DitherDude8mo agoI have no control what-so-ever over this project in any way, but I'm a little bit confused over your post (don'b blame yourself I'm also tired). So to clarify:
- user creates PR.
- if (you are collaborator) -> skip/ignore/allow PR
- otherwise if (PR does not have corrsponding issue) OR (PR author is not assigned
anto said corresponding issue) -> close PR - otherwise wait for admin to delegate to another account/contributor?
And then I don't understand how your final paragraph relates to vouch as a project...
igalklebanov8mo agootherwise if (PR does not have corrsponding issue) OR (PR author is not assigned an issue) -> close
PR author is not assigned an to corresponding issue.
And then I don't understand how your final paragraph relates to vouch as a project...
Vouch is a set of tools enabling a trust network. The end goal is maintainers not having to deal with a bunch of dumb slop drive by pull requests.
Vouched accounts can still produce a lot of pull requests (given the tooling today) and they can submit competing pull requests for the same issues. This is extra work for maintainers.
I believe assigning an account to an issue is a form of limited vouching. It can be combined with the core concept of this project in different ways.
One is to configure auto-closing of pull requests to also enforce the issue stuff - as described in original post.
Another could be to deny assigning issues to denounced accounts.
Another could be auto-assign issue to vouched accounts that ask to be assigned to an issue.
igalklebanov8mo agootherwise if (PR does not have corrsponding issue) OR (PR author is not assigned an issue) -> close
PR author is not assigned an to corresponding issue.
And then I don't understand how your final paragraph relates to vouch as a project...
Vouch is a set of tools enabling a trust network. The end goal is maintainers not having to deal with a bunch of dumb slop drive by pull requests.
Vouched accounts can still produce a lot of pull requests (given the tooling today) and they can submit competing pull requests for the same issues. This is extra work for maintainers.
I believe assigning an account to an issue is a form of limited vouching. It can be combined with the core concept of this project in different ways.
One is to configure auto-closing of pull requests to also enforce the issue stuff - as described in original post.
Another could be to deny assigning issues to denounced accounts.
Another could be auto-assign issue to vouched accounts that ask to be assigned to an issue.
igalklebanov8mo agootherwise if (PR does not have corrsponding issue) OR (PR author is not assigned an issue) -> close
PR author is not assigned an to corresponding issue.
And then I don't understand how your final paragraph relates to vouch as a project...
Vouch is a set of tools enabling a trust network. The end goal is maintainers not having to deal with a bunch of dumb slop drive by pull requests.
Vouched accounts can still produce a lot of pull requests (given the tooling today) and they can submit competing pull requests for the same issues. This is extra work for maintainers.
I believe assigning an account to an issue is a form of limited vouching. It can be combined with the core concept of this project in different ways.
One is to configure auto-closing of pull requests to also enforce the issue stuff - as described in original post.
Another could be to deny assigning issues to denounced accounts.
Another could be auto-assign issue to vouched accounts that ask to be assigned to an issue.
DitherDude8mo agoI see. I will update my prior comment.
DitherDude8mo agoI see. I will update my prior comment.
DitherDude8mo agoI see. I will update my prior comment.
davidvasandani8mo agoGo see every zed. Zzz****c
davidvasandani8mo agoGo see every zed. Zzz****c
igalklebanov8mo agoigalklebanov8mo agootherwise wait for admin to delegate to another account/contributor?
Don't care. That's up to each project and its process. Some delegate, some review themselves.
mitchellh8mo agoLooks like we could actually support this with closingIssuesReferences via GraphQL and our Nu has the ability to query GraphQL already so yeah, this is possible.
I think this is actually two separate features:
check-prshould support something like--require-issuethat just requires that some issue is referenced to be closedcheck-prshould also support--require-issue-assignmentthat also requires at least one of the closed issues is assigned to the submitter.
Would this work?
igalklebanov8mo ago@mitchellh yeah that would work. Should I create separate issues for tracking?
https://github.com/mitchellh/vouch/issues/6#issuecomment-3865863846 has 2 more feature ideas.
mitchellh8mo agohttps://github.com/mitchellh/vouch/issues/6#issuecomment-3865863846 has 2 more feature ideas.
I read the comment and not sure I see them. They sound covered by my proposals. What did I miss?
mitchellh8mo agoI pinned my comment as the answer here and changed the title. If there's other stuff to add I'll do so!
igalklebanov8mo agoI read the comment and not sure I see them. They sound covered by my proposals. What did I miss?
Just some ideas around issues and manage-by-issue.
There's "deny assigning issues to denounced accounts." but seeing that check-pr already auto-closes for denounced users, this one can be ignored.
There's "auto-assign issue to vouched accounts that ask to be assigned to an issue." which can be "add assign-keyword so vouched accounts can assign themselves to issues without collaborator help" for manage-by-issue.
Outside of that previous comment:
Maybe "unassign newly denounced account from any issues in the repo" for manage-by-issue after a denounce comment is created?
I have no control what-so-ever over this project in any way, but I'm a little bit confused over your post (don'b blame yourself I'm also tired). So to clarify:
anto said corresponding issue) -> close PRAnd then I don't understand how your final paragraph relates tovouchas a project...