observed in https://github.com/conda/rattler/pull/2126#issuecomment-3969570721 workflow: https://github.com/conda/rattler/blob/bb93194fe4cc50eb92976d932c196a316f7f1e3b/.github/workflows/vouch-manage-by-issue.yml, https://github.com/conda/rattler/actions/runs/22463709957/job/65064417973?pr=2126
I would have expected that vouch updates the denounced entry in VOUCHED.td with the reason provided. Instead, vouch didn't do anything with the message ... is already denounced. Probably the same issue holds when vouching (didn't test this)
Activity
6
mitchellh8mo agoGood point, we should update the reason field, I agree.
mitchellh8mo agoGood point, we should update the reason field, I agree.
RowanDavitt7mo agoHi, I'm new here. I like the idea behind this project and I would like to contribute.
I think I know how to fix this, it should be pretty straight forward (just ignoring the check in gh-apply-action if the action has a reason). Is it ok if I fix this?
RowanDavitt7mo agoHi, I'm new here. I like the idea behind this project and I would like to contribute.
I think I know how to fix this, it should be pretty straight forward (just ignoring the check in gh-apply-action if the action has a reason). Is it ok if I fix this?
madhavajay6mo agoHi All, I took a crack at fixing this on my own fork: https://github.com/madhavajay/vouch/pull/2
The first commit adds tests and verifies the behavior and the second one fixes the issue.
Good point, we should update the reason field, I agree.