7c:I[154500,[["$2",["$3","$4"],[14146,1120]],["$5",["$6","$7","$8","$9","$a","$b"],[39699,26937,10148,30255,12010,71004]]],"IconMark"] 79:T11c3,## Summary Fixes #16114 by refreshing floating-workspace exclusions when personal window rules register after saved workspace modes. This implements the change notification suggested in the issue. The first matching window now stays outside the floating mode's ownership, just like subsequent matching windows. Ending floating mode leaves these windows floating. ## Why the first window is affected The shipped `hyprland.lua` loads saved workspace modes through `default.hypr.toggles` before its personal-configuration section. A saved floating mode builds its opening rules from the float patterns currently recorded in `o.floating_apps`. A later `o.window(..., { float = true })` records a new pattern, but the generated exclusions previously stayed unchanged. The first matching window therefore received the mode's size and opening tag. `claim_opened()` claimed that window and refreshed the rules, making subsequent matching windows behave correctly. The incorrect ownership also caused the first window to become tiled when floating mode ended. ## Fix logic 1. Track whether `o.window()` records a float pattern or a class/title-to-tag relationship. 2. After registering the window rule, notify `o.floating_apps_changed` when that registry changed. 3. Set that hook to `sync_open_rules()` in the workspace-mode module, so exclusions are current before the first matching window opens. Notifying for both float rules and tagging rules handles either registration order. 4. Clear the previous hook when helpers reload, avoiding calls into the preceding configuration's workspace-mode state. Unrelated window rules do not trigger a refresh. The fix uses the existing rule-generation path and adds no polling or configuration migration. ## Regression coverage The added regression fails against unchanged production code with `a late class float rule did not refresh the first-window exclusion`, then passes with this patch. Five new regression groups cover late class/title rules, either half of a late tag relationship, both tag-related rules registered late in either order, multiple floating workspaces and disabled modes, and avoiding unrelated refreshes or stale callbacks after helpers reload. Focused validation completed on the submitted sources: | Suite | Passing checks | | --- | ---: | | Floating workspaces | 45 | | Workspace layout | 15 | | Workspace-mode migration | 2 | | **Total** | **62** | ```bash OMARCHY_PATH="$PWD" bash test/shell.d/hyprland-floating-workspaces-test.sh OMARCHY_PATH="$PWD" bash test/shell.d/hyprland-workspace-layout-test.sh OMARCHY_PATH="$PWD" bash test/shell.d/workspace-layout-mode-migration-test.sh luac -p default/hypr/helpers.lua luac -p default/hypr/workspace-modes.lua bash -n test/shell.d/hyprland-floating-workspaces-test.sh git diff --check ``` ## Native before/after result Reproduced using the real Omarchy modules in a sandboxed, nested Hyprland 0.56.2 compositor accelerated by a Radeon 8060S on a Ryzen AI Max+ PRO 395. The configuration restores a floating workspace before registering the personal rule. Two matching foot terminals request 100×8 cells, resolving to 600×120 pixels in this fixture; an ordinary terminal checks that workspace mode still manages normal windows. | Observation | Unchanged upstream | With this patch | | --- | --- | --- | | First class-matching terminal | 436×578, incorrectly mode-owned | 600×120, unclaimed | | Second class-matching terminal | 600×120, unclaimed | 600×120, unclaimed | | First matching terminal when floating mode ends | Incorrectly tiled | Remains floating at 600×120 | | Ordinary control terminal | Mode-owned, then tiled on mode exit | Mode-owned, then tiled on mode exit | All 16 native comparison assertions passed, including title-rule ownership, mode exit, and completion without configuration errors. Before/after screenshots were also inspected. ### Validation scope The title-only case also stops being claimed and remains floating on mode exit. In this minimal nested configuration, however, its first terminal negotiates 682×850 even with the personal rule registered early on unchanged upstream. The patched late-rule case matches that unaffected early-rule control. This patch corrects stale exclusions and mode ownership; it does not establish a general fix for initial title-based size negotiation. The comparison uses current upstream modules in an isolated configuration, rather than a full installed Omarchy 4.5 session. Confirmation in the reporter's complete configuration would be useful. 7a:Te1d,

Confidence Score: 5/5

**[Medium impact]** The PR appears safe to merge; no actionable issues were found.

Summary

Updates floating\-workspace exclusions as personal window rules are registered, before the first matching window opens. - Late personal window rules now update floating\-workspace exclusions. No actionable issues were found. Review checks were based on source inspection and a clean `git diff --check`; no runtime or visual verification was performed.

Diagram

```mermaid %%{init: {'theme': 'neutral'}}%% flowchart TD A[Personal window rule] --> B[Update floating-app records] B --> C[Register the window rule] C --> D{Relevant records changed?} D -->|Yes, callback installed| E[Refresh opening rules] E --> F[Exclude apps with their own float rules] D -->|No| G[No refresh] ```

_{Reviews (1) · Last reviewed commit: ["Refresh floating workspace exclusions fo..."](https://github.com/omacom/omarchy/commit/ecd08b0d70d5368369111fd2835faadd1982f5d0) · [Reviewed by Greptile](https://www.greptile.com/?utm_source=greptile_review&utm_medium=github&utm_campaign=review_public&utm_content=omacom/omarchy)} 64:["$","$L76",null,{"entries":[{"key":["platform",{"userId":"anon"},"pulls","page",{"owner":"omacom","repo":"omarchy","pullNumber":16143}],"data":{"repositoryId":"3671","detail":{"author":{"avatarUrl":"https://cdn.trylle.com/media/images/6cee1be6c145ae4c32729aa6d088a106?key=AQIEXuoODnNIgyp%2FbLrORPl7CDPjeykgIafOD0hnsnd70Ahx259apCPATyocupjPxPaxbYWqmvGMR9yYlTxiwlhRD9yPK%2F3vBt6WwhjZvUcE8uD2DaHxQaB1IwFXsD1BiO%2BE2ilheaAzhXM6b3r0JDi%2B0oz6yeypvoImArLQhTJSheSJ9wpPhAFIDA%3D%3D","externalProvider":"github","login":"zihaomu","type":"User","url":"https://github.com/zihaomu"},"authorId":"16487352","baseRefName":"quattro","closedAt":null,"comments":1,"createdAt":"2026-10-21T08:00:42Z","headRefName":"zihaomu/fix/16114-late-floating-rules","id":"4940169","isDraft":false,"labels":[],"number":16143,"repository":{"name":"omarchy","owner":"omacom","provider":"forgejo"},"state":"open","title":"Refresh floating workspace exclusions for late personal rules","updatedAt":"2026-10-21T08:03:34Z","url":"https://trylle.com/omacom/omarchy/pulls/16143","body":"$79","additions":97,"deletions":0,"changedFiles":3,"commits":1,"reviewComments":0,"headSha":"ecd08b0d70d5368369111fd2835faadd1982f5d0","baseSha":"087f73d899b456ce5275ebf27294d379585fbdb1","headRepoOwner":"omacom","headRepoName":"omarchy","isMerged":false,"mergeCommitSha":null,"mergedBy":null,"mergeable":true,"mergeableState":"clean","conflictingFiles":null,"requestedTeams":[],"requestedReviewers":[],"graphqlId":"issue:16143","reactions":{"counts":{"+1":1},"viewerReacted":null,"userLoginsByContent":{"+1":["greptile-apps[bot](github)"]}}},"comments":[{"id":26900844,"graphqlId":"26900844","body":"$7a","createdAt":"2026-10-21T08:03:30Z","author":{"avatarUrl":"https://cdn.trylle.com/media/images/d5fdefbe765e9f429d38a31328621291?key=Acl0%2BlhblDOxCrSlqfonNDhgrt1LwjH88FRgEld3W8TJMWD14w5hVMk945%2FUo6%2F4SXM8sWkkR1IS3%2FPkJicqQw3Nzkwzis1r900F6Ii81AW%2B6%2FgoEHT7u6ClQhGHk5zI5yHvly2ZTjc6HDW38z1iK%2FBzByCTQdN9niTDbBlKfNdTv6bYqay%2Boc9at4A%3D","externalProvider":"github","login":"greptile-apps[bot]","type":"Bot","url":"https://github.com/apps/greptile-apps"}}],"commits":[{"sha":"ecd08b0d70d5368369111fd2835faadd1982f5d0","message":"Refresh floating workspace exclusions for late personal rules\n\nNotify workspace modes after float patterns or tag relationships change, before the first matching window opens. Clear the hook when helpers reload and cover late rules, tag ordering, multiple workspaces, and callback lifetime.\n","createdAt":"2026-10-21T15:57:54+08:00","author":{"avatarUrl":"","login":"","name":"ZihaoMu","type":"User","url":""},"verification":{"verified":false,"reason":"gpg.error.not_signed_commit"}}],"events":[],"reviews":[],"stackEvents":[],"commentPagination":{"totalCount":1,"perPage":30,"loadedPages":[1]},"eventPagination":{"loadedPages":[1],"hasMore":false},"headRefDeleted":false},"fetchedAt":1792621576449}],"children":"$L7b"}] 66:null 6c:[["$","title","0",{"children":"Commits · Refresh floating workspace exclusions for late personal rules · omacom/omarchy | Trylle"}],["$","meta","1",{"name":"description","content":"Commits on Refresh floating workspace exclusions for late personal rules ( 16143) in omacom/omarchy."}],["$","meta","2",{"name":"application-name","content":"Trylle"}],["$","link","3",{"rel":"manifest","href":"/manifest.json","crossOrigin":"$undefined"}],["$","meta","4",{"name":"keywords","content":"Commits · Refresh floating workspace exclusions for late personal rules · omacom/omarchy, omacom/omarchy, omacom/omarchy repository, omarchy, Shell repository, source code, trylle, agent-native git platform, git platform for agents and humans, git platform for ai agents, coding agent pull requests, ai code review, repository automation, stacked pull requests, two-way github sync, github-compatible actions, try cli"}],["$","meta","5",{"name":"robots","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","6",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","7",{"name":"googlebot","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","8",{"name":"twitter:domain","content":"trylle.com"}],["$","meta","9",{"name":"twitter:url","content":"https://trylle.com/omacom/omarchy/pulls/16143/commits"}],["$","link","10",{"rel":"canonical","href":"https://trylle.com/omacom/omarchy/pulls/16143/commits"}],["$","meta","11",{"name":"format-detection","content":"telephone=no"}],["$","meta","12",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","13",{"name":"apple-mobile-web-app-title","content":"Trylle"}],["$","meta","14",{"name":"apple-mobile-web-app-status-bar-style","content":"black-translucent"}],["$","meta","15",{"property":"og:title","content":"Commits · Refresh floating workspace exclusions for late personal rules · omacom/omarchy | Trylle"}],["$","meta","16",{"property":"og:description","content":"Commits on Refresh floating workspace exclusions for late personal rules ( 16143) in omacom/omarchy."}],["$","meta","17",{"property":"og:url","content":"https://trylle.com/omacom/omarchy/pulls/16143/commits"}],["$","meta","18",{"property":"og:site_name","content":"Trylle"}],["$","meta","19",{"property":"og:locale","content":"en_US"}],["$","meta","20",{"property":"og:image","content":"https://trylle.com/api/og.png?kind=repo&owner=omacom&repo=omarchy"}],["$","meta","21",{"property":"og:image:secure_url","content":"https://trylle.com/api/og.png?kind=repo&owner=omacom&repo=omarchy"}],["$","meta","22",{"property":"og:image:type","content":"image/png"}],["$","meta","23",{"property":"og:image:width","content":"1200"}],["$","meta","24",{"property":"og:image:height","content":"630"}],["$","meta","25",{"property":"og:image:alt","content":"omacom/omarchy repository preview on Trylle"}],["$","meta","26",{"property":"og:type","content":"website"}],["$","meta","27",{"name":"twitter:card","content":"summary_large_image"}],["$","meta","28",{"name":"twitter:site","content":"@trylle"}],["$","meta","29",{"name":"twitter:title","content":"Commits · Refresh floating workspace exclusions for late personal rules · omacom/omarchy | Trylle"}],["$","meta","30",{"name":"twitter:description","content":"Commits on Refresh floating workspace exclusions for late personal rules ( 16143) in omacom/omarchy."}],["$","meta","31",{"name":"twitter:image","content":"https://trylle.com/api/og.png?kind=repo&owner=omacom&repo=omarchy"}],["$","meta","32",{"name":"twitter:image:alt","content":"omacom/omarchy repository preview on Trylle"}],["$","link","33",{"rel":"icon","href":"/favicon.png","type":"image/png"}],["$","link","34",{"rel":"apple-touch-icon","href":"/logo192.png"}],["$","$L7c","35",{}]]

Commits on Wed, Oct 21, 2026