78:Tea5,## Summary Opening **Verify → Scan** crashes every minified release build (2.0.x, any device). Debug builds aren't minified, so they never show it. Fixes #878, fixes #970. Root cause, from the retraced crash and the startup logcat of a release build: ```text QRCodeAnalyzer. (VerificationSheet.kt) BarcodeScanning.getClient() → NullPointerException: ML Kit was never initialized because at startup: MlKitInitProvider.onCreate ComponentDiscovery: Could not instantiate CommonComponentRegistrar, VisionCommonRegistrar, BarcodeRegistrar NoSuchMethodException: [] ← R8 full mode removed the no-arg constructors ``` The fix keeps those constructors. It follows the same pattern as the existing Room rule: ```diff # app/proguard-rules.pro +-keepclassmembers class * implements com.google.firebase.components.ComponentRegistrar { + (); +} ``` The Scan tab also gets a fallback and feedback: ```diff - # rejected codes did nothing + + → handleCode(clipboard text) + handleCode: success → toast "Verification requested" + failure → inline "Invalid or expired code, or this person isn't connected nearby" ``` - **Paste button:** verifies a `bitchat://verify` link read with another QR app. This helps when the camera is unavailable or camera permission is denied. - **Rejected camera scans:** codes that are invalid, expired, or from a peer who isn't connected used to do nothing. They now show the same inline message. It's inline rather than a toast because Android 12+ cuts toasts to two lines. - **Strings:** the button and success message reuse the existing, already-translated `verify_paste_label` and `verify_scanned`. The new `verify_scan_failed` is added to every locale, in English where that locale's verify strings are still in English. ## Evidence The tests below used a minified release build signed with the debug key, on an Android 16 emulator unless noted otherwise. - **Before** (`main`): - Opening Scan closes the app. - Startup logcat shows `Could not instantiate …Registrar` three times. - Removing `ImplementationMode.EMBEDDED`, as #976 and #974 do, still crashes the same way. **After:** - No registrar warnings. - The Scan tab shows the camera preview and nothing crashes. - The same result on a physical Android 16 phone. - **Camera path:** a physical phone scanning an emulator's QR code shows the inline "not connected nearby" message. That's expected, because an emulator can't join a phone's mesh. It shows the camera and ML Kit decoding work end to end. - **Successful verification:** two emulators meshed over the emulator's virtual Bluetooth. - Pasting emulator A's verify link on emulator B shows "Verification requested". - B then lists A with the verified badge and the message "Verified ⟨A⟩". - **Paste with an empty clipboard:** shows the inline error and doesn't crash. - **CI tasks:** `testDebugUnitTest` passes (638 tests, 0 failures). `lintDebug` reports no new issues in the changed files. Mesh Lab wasn't run: no transport, routing, protocol or crypto code changed. ## Merge Danger **Door:** two-way **Blast Radius:** small - The keep rule only matches classes implementing `ComponentRegistrar`, which here are ML Kit's three registrars. - The UI change is limited to the Scan tab. - Related PRs #976, #900 and #899 change the CameraX viewfinder setup but don't address this crash. For #976's change, I checked this on the release build. 🤖 Generated with [Claude Code](https://claude.com/claude-code) 79:T488, ## Codex Review Summary This comment shows the latest Codex review activity on this pull request. | Review | Status | Commit | Review trigger | | --- | --- | --- | --- | | 📝 **Code Review** | ✅ **Completed** 2026-10-22T18:12:34.023276Z | `5160efc` | PR opened |

ℹ️ About Codex in GitHub

[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

7a:T6e9,**Review: looks good to merge ✅** I confirmed the root cause with an R8 build. I ran `minifyReleaseWithR8` with main's `proguard-rules.pro` and then with this PR's rules. - **With main's rules,** the mapping keeps `CommonComponentRegistrar`, `VisionCommonRegistrar` and `BarcodeRegistrar` but drops their no-arg `()`. The `firebase-components` consumer rule (`-keep class * implements ComponentRegistrar`) keeps the classes but not the constructors in R8 full mode. - **With this PR's rules,** all three keep `()`. I also checked every other reflection-loaded `` class in the merged release manifest: the CameraX config provider, WorkManager, the lifecycle, emoji and profile installers, and the okhttp initializer. They all keep their constructors under main's rules, so only these three registrars needed the new rule. Nits (non-blocking): - Paste with an empty clipboard, or scanning a QR code that isn't a bitchat code, shows the "invalid or expired" message. A separate message would be clearer. - `BarcodeScanning.getClient()` still runs unguarded inside `remember {}`. If ML Kit fails for some other reason, the screen still crashes instead of falling back to paste. - About 17 of the 33 locale files get the English text copied in (ar, bn, fa, fil, hi, id, ka, ko, mg, ne, nl, pa-rPK, sv, th, tr, ur, vi). At runtime this is the same as falling back to English, but it hides the string from MissingTranslation lint and translators. Prefer leaving those out. The new `values-eu` gets no entry. - `LocalClipboardManager` is deprecated (warning only). No CI has run on this PR yet; it needs workflow approval. It merges cleanly with main. It overlaps #984 in `proguard-rules.pro` (same keep rule), so only one of them should carry it. 7b:T6e9,**Review: looks good to merge ✅** I confirmed the root cause with an R8 build. I ran `minifyReleaseWithR8` with main's `proguard-rules.pro` and then with this PR's rules. - **With main's rules,** the mapping keeps `CommonComponentRegistrar`, `VisionCommonRegistrar` and `BarcodeRegistrar` but drops their no-arg `()`. The `firebase-components` consumer rule (`-keep class * implements ComponentRegistrar`) keeps the classes but not the constructors in R8 full mode. - **With this PR's rules,** all three keep `()`. I also checked every other reflection-loaded `` class in the merged release manifest: the CameraX config provider, WorkManager, the lifecycle, emoji and profile installers, and the okhttp initializer. They all keep their constructors under main's rules, so only these three registrars needed the new rule. Nits (non-blocking): - Paste with an empty clipboard, or scanning a QR code that isn't a bitchat code, shows the "invalid or expired" message. A separate message would be clearer. - `BarcodeScanning.getClient()` still runs unguarded inside `remember {}`. If ML Kit fails for some other reason, the screen still crashes instead of falling back to paste. - About 17 of the 33 locale files get the English text copied in (ar, bn, fa, fil, hi, id, ka, ko, mg, ne, nl, pa-rPK, sv, th, tr, ur, vi). At runtime this is the same as falling back to English, but it hides the string from MissingTranslation lint and translators. Prefer leaving those out. The new `values-eu` gets no entry. - `LocalClipboardManager` is deprecated (warning only). No CI has run on this PR yet; it needs workflow approval. It merges cleanly with main. It overlaps #984 in `proguard-rules.pro` (same keep rule), so only one of them should carry it. 62:["$","$L75",null,{"entries":[{"key":["platform",{"userId":"anon"},"pulls","page",{"owner":"permissionlesstech","repo":"bitchat-android","pullNumber":982}],"data":{"repositoryId":"1518","detail":{"author":{"avatarUrl":"https://cdn.trylle.com/media/images/837870bbeff3f9d9c5df36eb8dba7c2c?key=AXxApMV%2FuJzZtZAPlPornonWwpNICuQhGPwz1aP%2BZQNdGljtOnV%2BF8xNvKld0vCeHokK%2B3VmqTswovP0g%2FBvv6AyOOV%2FKnFMq9JZB7b4AQvolx7DWqrM03APpHjZv9kp8%2BN%2BgQw5K%2FpXQen4j1IjK%2Bk7MzkOXJBf4J%2FMyYSveQ7Q8xtxtK%2FEeCLe","externalProvider":"github","login":"tranKILL","type":"User","url":"https://github.com/tranKILL"},"authorId":"5702032","baseRefName":"main","closedAt":null,"comments":3,"createdAt":"2026-10-22T18:08:23Z","headRefName":"tranKILL/fix-qr-scanner","id":"4944165","isDraft":false,"labels":[],"number":982,"repository":{"name":"bitchat-android","owner":"permissionlesstech","provider":"forgejo"},"state":"open","title":"Fix QR scanner crash in release builds and add paste fallback","updatedAt":"2026-10-24T23:10:16Z","url":"https://trylle.com/permissionlesstech/bitchat-android/pulls/982","body":"$78","additions":80,"deletions":6,"changedFiles":36,"commits":1,"reviewComments":1,"headSha":"5160efc6786741910e33f753dd87c3a35e17e902","baseSha":"20501fdfe0d56c7705c377d4a263b01d8f38eeeb","headRepoOwner":"permissionlesstech","headRepoName":"bitchat-android","isMerged":false,"mergeCommitSha":null,"mergedBy":null,"mergeable":false,"mergeableState":"dirty","conflictingFiles":["app/proguard-rules.pro"],"requestedTeams":[],"requestedReviewers":[],"graphqlId":"issue:982","reactions":{"counts":{"+1":1},"viewerReacted":null,"userLoginsByContent":{"+1":["chatgpt-codex-connector[bot](github)"]}}},"comments":[{"id":26933247,"graphqlId":"26933247","body":"$79","createdAt":"2026-10-22T18:08:35Z","author":{"avatarUrl":"https://cdn.trylle.com/media/images/fdedb714e9add836fd78428365411061?key=AbTl84PUpcB4AQFwbMXuaKdUswwUmlivTOVSlxm3nEp0jqDQNNmsjqx0pi8Gv5DD6U88zm8KvjR%2B2dq3EuWbeQbbulrG%2BlcEiJ5GsJS7eQphSJmBFHIx4QT60r62zC1isNJWQJxzZY0LYUmSwyBvW%2BiCNKisU%2BSqP%2Bj2mf0aULYPwb3WpCDJRPYTyYg%3D","externalProvider":"github","login":"chatgpt-codex-connector[bot]","type":"Bot","url":"https://github.com/apps/chatgpt-codex-connector"}},{"id":26933248,"graphqlId":"26933248","body":"But I have already successfully tested it on Android 16","createdAt":"2026-10-23T03:13:39Z","author":{"avatarUrl":"https://cdn.trylle.com/media/images/9bb792f2fdfb69d136e96792522839b8?key=Ac3XPyeFyV5BjEFWAUVbfvvGk%2BbOwlexIZ4laWc7H5xJWt0Bv08C759JLmMvYYj2H4X9KvRtQY68QvqGkk1Fd2igiRXkQqVAHuX5BIIBGYOlWfSGvwxqnCOhdKGP4hk0ZQSk9oMpkrpd4sIPpmwRCIVljB0wf6unwQ9XOZwncXUI9oJdlfb1vMNAnaQ%3D","externalProvider":"github","login":"zhu120212","type":"User","url":"https://github.com/zhu120212"}}],"commits":[{"sha":"5160efc6786741910e33f753dd87c3a35e17e902","message":"Fix QR scanner crash in release builds and add paste fallback\n\nOpening the verification Scan tab crashes every minified release build\n(#878, #970). ML Kit instantiates its component registrars by name from\nthe manifest, but R8 full mode strips their no-argument constructors, so\nML Kit never initializes and BarcodeScanning.getClient() throws a\nNullPointerException. Keep those constructors, as already done for Room.\n\nAdd a \"Paste verification URL\" button so a bitchat://verify link read\nby another QR app can still be verified when the camera is unavailable.\nBoth camera scans and pasted links now report when the code is invalid,\nexpired, or the peer is not connected, instead of failing silently.\n\nCo-Authored-By: Claude Opus 5.5 (1M context) \n","createdAt":"2026-10-22T19:13:42+02:00","author":{"avatarUrl":"","login":"","name":"tranKILL.be","type":"User","url":""},"verification":{"verified":false,"reason":"gpg.error.not_signed_commit"}}],"events":[{"id":26933291,"event":"reviewed","createdAt":"2026-10-24T23:10:16Z","actor":{"avatarUrl":"https://cdn.trylle.com/media/images/95dcc8c9890ad1354665bdd09764d59d?key=AeFNlU31IU6e9ClC2xdb6F5S7vx7ufxYJhbP%2FnuC1UfnB5ysBJxJE%2FdIhbDHKqLbyEGlbUxJNEV9tAgmpYhD47g993boXGDL%2Bv494SJwYHnYoLD7ABV88f00ngvKjQ3LZVvW434SQmVSgwYSHXOnU9UsvPxhZOqcHTVv4coLAj37EJOSJVGJ6H9QPw%3D%3D","externalProvider":"github","login":"callebtc","type":"User","url":"https://github.com/callebtc"},"reviewId":3623717,"reviewState":"COMMENT","body":"$7a"}],"reviews":[{"id":3623717,"state":"COMMENT","author":{"avatarUrl":"https://cdn.trylle.com/media/images/95dcc8c9890ad1354665bdd09764d59d?key=AeFNlU31IU6e9ClC2xdb6F5S7vx7ufxYJhbP%2FnuC1UfnB5ysBJxJE%2FdIhbDHKqLbyEGlbUxJNEV9tAgmpYhD47g993boXGDL%2Bv494SJwYHnYoLD7ABV88f00ngvKjQ3LZVvW434SQmVSgwYSHXOnU9UsvPxhZOqcHTVv4coLAj37EJOSJVGJ6H9QPw%3D%3D","externalProvider":"github","login":"callebtc","type":"User","url":"https://github.com/callebtc"},"body":"$7b","submittedAt":"2026-10-24T23:10:16Z","official":false}],"stackEvents":[],"commentPagination":{"totalCount":3,"perPage":30,"loadedPages":[1]},"eventPagination":{"loadedPages":[1],"hasMore":false},"headRefDeleted":false},"fetchedAt":1793417568777}],"children":"$L7c"}] 64:null 6b:[["$","title","0",{"children":"Commits · Fix QR scanner crash in release builds and add paste fallback · permissionlesstech/bitchat-android | Trylle"}],["$","meta","1",{"name":"description","content":"Commits on Fix QR scanner crash in release builds and add paste fallback (#982) in permissionlesstech/bitchat-android."}],["$","meta","2",{"name":"application-name","content":"Trylle"}],["$","link","3",{"rel":"manifest","href":"/manifest.json","crossOrigin":"$undefined"}],["$","meta","4",{"name":"keywords","content":"Commits · Fix QR scanner crash in release builds and add paste fallback · permissionlesstech/bitchat-android, permissionlesstech/bitchat-android, permissionlesstech/bitchat-android repository, bitchat-android, Kotlin repository, source code, trylle, agent-native git platform, git platform for agents and humans, git platform for ai agents, coding agent pull requests, ai code review, repository automation, stacked pull requests, two-way github sync, github-compatible actions, try cli"}],["$","meta","5",{"name":"robots","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","6",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","7",{"name":"googlebot","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","8",{"name":"twitter:domain","content":"trylle.com"}],["$","meta","9",{"name":"twitter:url","content":"https://trylle.com/permissionlesstech/bitchat-android/pulls/982/commits"}],["$","link","10",{"rel":"canonical","href":"https://trylle.com/permissionlesstech/bitchat-android/pulls/982/commits"}],["$","meta","11",{"name":"format-detection","content":"telephone=no"}],["$","meta","12",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","13",{"name":"apple-mobile-web-app-title","content":"Trylle"}],["$","meta","14",{"name":"apple-mobile-web-app-status-bar-style","content":"black-translucent"}],["$","meta","15",{"property":"og:title","content":"Commits · Fix QR scanner crash in release builds and add paste fallback · permissionlesstech/bitchat-android | Trylle"}],["$","meta","16",{"property":"og:description","content":"Commits on Fix QR scanner crash in release builds and add paste fallback (#982) in permissionlesstech/bitchat-android."}],["$","meta","17",{"property":"og:url","content":"https://trylle.com/permissionlesstech/bitchat-android/pulls/982/commits"}],["$","meta","18",{"property":"og:site_name","content":"Trylle"}],["$","meta","19",{"property":"og:locale","content":"en_US"}],["$","meta","20",{"property":"og:image","content":"https://trylle.com/api/og.png?kind=repo&owner=permissionlesstech&repo=bitchat-android"}],["$","meta","21",{"property":"og:image:secure_url","content":"https://trylle.com/api/og.png?kind=repo&owner=permissionlesstech&repo=bitchat-android"}],["$","meta","22",{"property":"og:image:type","content":"image/png"}],["$","meta","23",{"property":"og:image:width","content":"1200"}],["$","meta","24",{"property":"og:image:height","content":"630"}],["$","meta","25",{"property":"og:image:alt","content":"permissionlesstech/bitchat-android repository preview on Trylle"}],["$","meta","26",{"property":"og:type","content":"website"}],["$","meta","27",{"name":"twitter:card","content":"summary_large_image"}],["$","meta","28",{"name":"twitter:site","content":"@trylle"}],["$","meta","29",{"name":"twitter:title","content":"Commits · Fix QR scanner crash in release builds and add paste fallback · permissionlesstech/bitchat-android | Trylle"}],["$","meta","30",{"name":"twitter:description","content":"Commits on Fix QR scanner crash in release builds and add paste fallback (#982) in permissionlesstech/bitchat-android."}],["$","meta","31",{"name":"twitter:image","content":"https://trylle.com/api/og.png?kind=repo&owner=permissionlesstech&repo=bitchat-android"}],["$","meta","32",{"name":"twitter:image:alt","content":"permissionlesstech/bitchat-android repository preview on Trylle"}],"$L7d","$L7e","$L7f","$L80"]

Commits on Thu, Oct 22, 2026