#1803
fix: keyboard-navigate command suggestions without swallowing send
Summary
Fixes #233. The suggestion list was rebuilt click-only: mentions got arrow keys, commands did not. Up and down move a highlight, tab inserts the highlighted command, escape hides the panel until the text changes.
Return still sends a finished command (/help) and a command that already has arguments (/msg alice). It only completes an incomplete prefix (/he becomes /help ), so opening the panel does not eat the key that runs the command.
Test plan
-
CommandSuggestionNavigationchecks (prefix vs finished alias vs arguments, arrow wrap) compiled and ran locally under Swift 5 and Swift 6. - On macOS, type
/h, arrow between/helpand/hug, tab to insert, and hit return on/helpitself to send. - Mention completion (arrows, tab, return) still completes the nickname instead of sending.
- Could not run
xcodebuildhere (no Xcode). CI covers the app build and the new test file.
Made with Cursor
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
We couldn’t complete this review. Comment
@codex reviewto try again.7756fafℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.