#1803

fix: keyboard-navigate command suggestions without swallowing send

Openchessing234wants to merge intofrom

Summary

Fixes #233. The suggestion list was rebuilt click-only: mentions got arrow keys, commands did not. Up and down move a highlight, tab inserts the highlighted command, escape hides the panel until the text changes.

Return still sends a finished command (/help) and a command that already has arguments (/msg alice). It only completes an incomplete prefix (/he becomes /help ), so opening the panel does not eat the key that runs the command.

Test plan

  • CommandSuggestionNavigation checks (prefix vs finished alias vs arguments, arrow wrap) compiled and ran locally under Swift 5 and Swift 6.
  • On macOS, type /h, arrow between /help and /hug, tab to insert, and hit return on /help itself to send.
  • Mention completion (arrows, tab, return) still completes the nickname instead of sending.
  • Could not run xcodebuild here (no Xcode). CI covers the app build and the new test file.

Made with Cursor

Activity

2
chatgpt-codex-connector[bot]6d ago

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

ReviewStatusCommitReview trigger
📝 Code Review⚠️ Failed 2026-10-24T14:44:37.374733Z
We couldn’t complete this review. Comment @codex review to try again.
7756fafPR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.