#1804
Pull Requests/permissionlesstech/bitchat/#1804

fix: encode embedded bitchat packets with the shared base64url helper

Openchessing234wants to merge intofrom
1 commit1 file changed+4-12

Summary

Refs #642. Jack's re-scope left one private encoder, in NostrEmbeddedBitChat. It did the same unpadded base64url as Base64URLCoding, so the four bitchat1: envelopes now call that. CashuTokenDecoder stays on its own decoder, which is lenient about the legacy . charset.

Test plan

  • Existing NostrProtocolTests decode bitchat1: acks produced by these envelopes. CI runs them.
  • Could not run xcodebuild here (no Xcode).

Made with Cursor

Activity

2
T
fix: encode embedded bitchat packets with the shared base64url helper
0b99b04
chatgpt-codex-connector[bot]6d ago

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

ReviewStatusCommitReview trigger
📝 Code Review⚠️ Failed 2026-10-24T14:49:07.357611Z
We couldn’t complete this review. Comment @codex review to try again.		0b99b04PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.