78:Tac5,## Summary Channel invites (#1513) lose a link to NSDataDetector in five languages: - **Arabic, Persian, Hebrew, Urdu:** NSDataDetector finds the deep link only as `bitchat://geohash`, with no geohash. Tapping that opens bitchat without opening the channel, because `MessageListView.handleOpenURL` rejects an empty geohash. In right-to-left text the link is also reordered: drawn on one line, it reads `u4pru/bitchat://geohash`. - **Korean:** NSDataDetector reads the App Store link as `…/id6748219622에서`, which apps.apple.com answers with a 404 in a desktop or Android browser. ## Cause `ChannelShare.payload` formatted with `locale: .current`. Given any locale, Foundation wraps every argument of a right-to-left format in bidi isolates (U+2068…U+2069), and NSDataDetector stops at the first one. The format's text decides it, not the locale: the Persian format gets isolates even with `en_US`, and the English format gets none with `fa_IR`. With `locale: nil` there are none. Korean's translation attaches the particle directly to the URL (`%2$@에서`), so NSDataDetector reads it as part of the URL, with or without a locale. ## Fix - Format the payload with `locale: nil`. Both arguments are plain strings, so the locale contributed nothing but the isolates. - Korean: one space, `%2$@에서` → `%2$@ 에서`. The rest of the translation is unchanged. No new keys and no other locale changes. In Swift the only behavior change is `locale: nil`; `payload(forGeohash:)` keeps its signature and its callers are untouched. Lookup and formatting are split into `payload(forGeohash:format:)` so the test can run every locale's format through the code that ships. CI runs in English, so the public function alone would only ever format the English string. The other `locale: .current` calls build text shown inside bitchat. The invite is the one formatted string that leaves through the share sheet. ## Test `everyLocaleKeepsBothInviteLinksIntact` reads every locale's `channel.share.payload` from the catalog (the same way `LocalizationCoverageTests` does), formats it with `payload(forGeohash:format:)`, and asserts that NSDataDetector finds the full deep link and the App Store URL. - With `locale: .current` put back and main's Korean string, it fails for ar, fa, he, ur (deep link) and ko (store link). Reverting only one half fails only that half's locales. - Locally, with xcodebuild, the full suites pass: macOS (2199 Swift Testing + 214 XCTest) and the iOS 26.5 simulator (2202 + 214). The new test also passes on the iOS 17.4 simulator. - The isolates and NSDataDetector's results are the same on macOS 27, the iOS 17.4 simulator, and the iOS 26.5 simulator. 🤖 Generated with [Claude Code](https://claude.com/claude-code) 79:T4d1, ## Codex Review Summary This comment shows the latest Codex review activity on this pull request. | Review | Status | Commit | Review trigger | | --- | --- | --- | --- | | 📝 **Code Review** | ⚠️ **Failed** 2026-10-25T23:00:35.680959Z
We couldn’t complete this review. Comment `@codex review` to try again. | `e14a4cc` | PR opened |

ℹ️ About Codex in GitHub

[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

7a:T60c,Keep channel invite links intact in every language In a channel invite shared from bitchat running in Arabic, Persian, Hebrew, or Urdu, the deep link was cut short. ChannelShare formatted the payload with `locale: .current`, and given any locale, Foundation wraps each argument of a right-to-left format in bidi isolates (U+2068 and U+2069). NSDataDetector stops at the first one and finds only `bitchat://geohash`, which the deep-link handler drops as an empty geohash, so a tap opens bitchat but not the channel. In right-to-left text the isolates also reorder the link: drawn on one line, it reads `u4pru/bitchat://geohash`. The payload is now formatted with no locale. Both arguments are plain strings, so the locale contributed nothing but the isolates. Lookup and formatting are split so the test can run every locale's format through the shipped code; CI runs in English, where the public function only ever formats the English string. Korean had a separate break: in `%2$@에서` the particle is attached to the App Store URL, NSDataDetector reads it as part of the URL, and apps.apple.com answers that URL with a 404 in a desktop or Android browser. A space before the particle keeps the URL clean; the wording is otherwise unchanged. The new test formats every locale's string and asserts that NSDataDetector finds both the full deep link and the App Store URL. With `locale: .current` and main's Korean string, it fails for ar, fa, he, and ur (deep link) and ko (store link). Co-Authored-By: Claude Opus 5.5 62:["$","$L75",null,{"entries":[{"key":["platform",{"userId":"anon"},"pulls","page",{"owner":"permissionlesstech","repo":"bitchat","pullNumber":1818}],"data":{"repositoryId":"1517","detail":{"author":{"avatarUrl":"https://cdn.trylle.com/media/images/769234ff2584b2af0ef3a8f2b6f606ad?key=AWgh7%2BJK6RDET%2BM4HZIW31jy7qRQWLuBlrpE3A9VERz5QisYmjNzM8VvLL0O61hqh%2Bc%2FBJRsrTm%2B3n3DZD9riQwWs11HixBU%2F9l0KAAsQKlJvSAiynRVJ9pdqjLY3%2Bz5%2F3qBFUfXqCnBIk4IcfPhkMLJFUx55HYBm0geKfB%2FOjRS7eNidwMZauaHSl0%3D","externalProvider":"github","login":"RodsF1","type":"User","url":"https://github.com/RodsF1"},"authorId":"166758014","baseRefName":"main","closedAt":null,"comments":1,"createdAt":"2026-10-25T22:59:18Z","headRefName":"unknown repository","id":"4957440","isDraft":false,"labels":[],"number":1818,"repository":{"name":"bitchat","owner":"permissionlesstech","provider":"forgejo"},"state":"open","title":"Keep channel invite links intact in every language","updatedAt":"2026-10-25T23:00:36Z","url":"https://trylle.com/permissionlesstech/bitchat/pulls/1818","body":"$78","additions":51,"deletions":7,"changedFiles":3,"commits":1,"reviewComments":0,"headSha":"e14a4cc3a1b3fcea6beb7e8d6b792a57ada0632a","baseSha":"04995f68e470a18d1fc99f86fa326c2a87bab4f2","headRepoOwner":"permissionlesstech","headRepoName":"bitchat","isMerged":false,"mergeCommitSha":null,"mergedBy":null,"mergeable":true,"mergeableState":"clean","conflictingFiles":null,"requestedTeams":[],"requestedReviewers":[],"graphqlId":"issue:1818"},"comments":[{"id":27021087,"graphqlId":"27021087","body":"$79","createdAt":"2026-10-25T22:59:34Z","author":{"avatarUrl":"https://cdn.trylle.com/media/images/fdedb714e9add836fd78428365411061?key=AbTl84PUpcB4AQFwbMXuaKdUswwUmlivTOVSlxm3nEp0jqDQNNmsjqx0pi8Gv5DD6U88zm8KvjR%2B2dq3EuWbeQbbulrG%2BlcEiJ5GsJS7eQphSJmBFHIx4QT60r62zC1isNJWQJxzZY0LYUmSwyBvW%2BiCNKisU%2BSqP%2Bj2mf0aULYPwb3WpCDJRPYTyYg%3D","externalProvider":"github","login":"chatgpt-codex-connector[bot]","type":"Bot","url":"https://github.com/apps/chatgpt-codex-connector"}}],"commits":[{"sha":"e14a4cc3a1b3fcea6beb7e8d6b792a57ada0632a","message":"$7a","createdAt":"2026-10-21T17:53:06-07:00","author":{"avatarUrl":"","login":"","name":"Rod Bahmanyari","type":"User","url":""},"verification":{"verified":false,"reason":"gpg.error.not_signed_commit"}}],"events":[],"reviews":[],"stackEvents":[],"commentPagination":{"totalCount":1,"perPage":30,"loadedPages":[1]},"eventPagination":{"loadedPages":[1],"hasMore":false},"headRefDeleted":false},"fetchedAt":1793414478964}],"children":"$L7b"}] 64:null 6b:[["$","title","0",{"children":"Commits · Keep channel invite links intact in every language · permissionlesstech/bitchat | Trylle"}],["$","meta","1",{"name":"description","content":"Commits on Keep channel invite links intact in every language (#1818) in permissionlesstech/bitchat."}],["$","meta","2",{"name":"application-name","content":"Trylle"}],["$","link","3",{"rel":"manifest","href":"/manifest.json","crossOrigin":"$undefined"}],["$","meta","4",{"name":"keywords","content":"Commits · Keep channel invite links intact in every language · permissionlesstech/bitchat, permissionlesstech/bitchat, permissionlesstech/bitchat repository, bitchat, Swift repository, source code, trylle, agent-native git platform, git platform for agents and humans, git platform for ai agents, coding agent pull requests, ai code review, repository automation, stacked pull requests, two-way github sync, github-compatible actions, try cli"}],["$","meta","5",{"name":"robots","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","6",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","7",{"name":"googlebot","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","8",{"name":"twitter:domain","content":"trylle.com"}],["$","meta","9",{"name":"twitter:url","content":"https://trylle.com/permissionlesstech/bitchat/pulls/1818/commits"}],["$","link","10",{"rel":"canonical","href":"https://trylle.com/permissionlesstech/bitchat/pulls/1818/commits"}],["$","meta","11",{"name":"format-detection","content":"telephone=no"}],["$","meta","12",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","13",{"name":"apple-mobile-web-app-title","content":"Trylle"}],["$","meta","14",{"name":"apple-mobile-web-app-status-bar-style","content":"black-translucent"}],["$","meta","15",{"property":"og:title","content":"Commits · Keep channel invite links intact in every language · permissionlesstech/bitchat | Trylle"}],["$","meta","16",{"property":"og:description","content":"Commits on Keep channel invite links intact in every language (#1818) in permissionlesstech/bitchat."}],["$","meta","17",{"property":"og:url","content":"https://trylle.com/permissionlesstech/bitchat/pulls/1818/commits"}],["$","meta","18",{"property":"og:site_name","content":"Trylle"}],["$","meta","19",{"property":"og:locale","content":"en_US"}],["$","meta","20",{"property":"og:image","content":"https://trylle.com/api/og.png?kind=repo&owner=permissionlesstech&repo=bitchat"}],["$","meta","21",{"property":"og:image:secure_url","content":"https://trylle.com/api/og.png?kind=repo&owner=permissionlesstech&repo=bitchat"}],["$","meta","22",{"property":"og:image:type","content":"image/png"}],["$","meta","23",{"property":"og:image:width","content":"1200"}],["$","meta","24",{"property":"og:image:height","content":"630"}],["$","meta","25",{"property":"og:image:alt","content":"permissionlesstech/bitchat repository preview on Trylle"}],["$","meta","26",{"property":"og:type","content":"website"}],["$","meta","27",{"name":"twitter:card","content":"summary_large_image"}],["$","meta","28",{"name":"twitter:site","content":"@trylle"}],["$","meta","29",{"name":"twitter:title","content":"Commits · Keep channel invite links intact in every language · permissionlesstech/bitchat | Trylle"}],["$","meta","30",{"name":"twitter:description","content":"Commits on Keep channel invite links intact in every language (#1818) in permissionlesstech/bitchat."}],["$","meta","31",{"name":"twitter:image","content":"https://trylle.com/api/og.png?kind=repo&owner=permissionlesstech&repo=bitchat"}],["$","meta","32",{"name":"twitter:image:alt","content":"permissionlesstech/bitchat repository preview on Trylle"}],["$","link","33",{"rel":"icon","href":"/favicon.png","type":"image/png"}],["$","link","34",{"rel":"icon","href":"/favicon-white.png","type":"image/png","media":"(prefers-color-scheme: dark)"}],"$L7c","$L7d"]

Commits on Thu, Oct 22, 2026