#151

possible WinMetadata corruption on Wine 11 in the Python installer?

OpenFelixOliverLangeopened 7mo ago

This isn't something I've run into (yet), but I noticed something that seemed off to me and which might create problems in the future.

When using a recent Wine version (like 11.0), the WinMetadata download is not required and as result, the python installer skips it by deploying Wine version checks (example). However, the function run_update deletes the WinMetadata folder and replaces it with the downloaded version without such version check (reference). Now because the installer initially (rightfully!) skips the WinMetadata download on Wine 11, this means that the content of the directory before deletion and after re-creation differ (because the re-creation uses the download whereas the initial setup doesn't). This could lean to a corruption of the directory after an update, especially as the content of the originally created WinMetadata folder may evolve with future Wine versions.

If you share this concern, I'd see two options:

  1. If corruption of this folder is not a concern in Wine 11+, then a version check as used elsewhere would do the trick (but has to cover the entire segment of folder deletion and recreation)
  2. If corruption remains a concern, run_update could create a backup of the present Winmetadata folder before an update and then restore that later. This might (?) work for all Wine versions, but might not be as effective when considering previous corruptions, so it could also be an alternative approach only used for newer Wine versions.

Activity

0

No activity yet.