#182
Replying on issues just not working
Description
When I'm leaving comments on the issue from diffkit, it's not added in actual issue on diffkit, but it will be added on the GitHub. So integration layer works, but something wrong with diffkit API.
Steps to Reproduce
- go to any issue
- write reply and hit send
Expected Behavior
an reply to show up..
Actual Behavior
nothing happening even after update
Screenshots
https://github.com/user-attachments/assets/3824c0da-9a7f-41b2-abfe-cdb61de7f016
Environment
- Browser: arc
- OS: macos
Worth narrowing this to whether the stale read is happening on the dashboard refetch, not GitHub refusing the mutation: posting already uses
octokit.rest.issues.createCommentand the UI callsinvalidateQuerieson success (seeDetailCommentBox/ reply flow,CommentReplyForm).The issue detail route loads
getIssuePageData(embedded comments via GraphQL → resourceissues.pageData.graphql.v2, split KV mode) (githubIssuePageQueryOptions+IssueDetailPage).createCommentonly bustsissues.comments/pulls.commentsand bumps cache namespaces; it does not bump thegithub_revalidation_signaltimestamps that driveisSignalNewerThanCacheingetGitHubResourceLocalFirst, while a webhookissue_commentpath does includeissue:owner/repo#n(github-revalidation.ts). So after an in-app comment, the React Query invalidation may refetch the server fn and still hit a locally cached issue page payload that predates the new comment until something else timestamps that signal or the legacy row ages out—that matches “visible on github.com but not in DiffKit until something else refreshes.”Things that would validate the theory quickly: reproduce with network tab showing the
/server fn response right after send; compare toissues.createCommentsucceeding. Fix direction to consider: after a successful comment, alsomarkGitHubRevalidationSignalsforgithubRevalidationSignalKeys.issueEntity(andpullEntitywhen the number is a PR), and/or explicitlybustGitHubCacheforissues.pageData.graphql.v2(and any REST issue-page resources) for that issue.Related background on keeping entity-scoped data in sync with signals: #160, #161, #179.