Improve repository experience by adding a commits browser

apps/dashboard/src/lib/github.functions.ts (1)

9591-9591: Use the list cache tier for paginated commits.

Line 9591 uses githubCachePolicy.detail.staleTimeMs; this endpoint is a time-sensitive list and should likely use githubCachePolicy.list.staleTimeMs for fresher history updates.

♻️ Suggested change

-			freshForMs: githubCachePolicy.detail.staleTimeMs,
+			freshForMs: githubCachePolicy.list.staleTimeMs,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/dashboard/src/lib/github.functions.ts` at line 9591, Replace the detail
cache tier with the list cache tier for this paginated commits response: change
the freshForMs assignment from githubCachePolicy.detail.staleTimeMs to
githubCachePolicy.list.staleTimeMs so the commits list uses the shorter/fresher
list stale time; update the object that sets freshForMs (the one referencing
githubCachePolicy.detail.staleTimeMs) to reference
githubCachePolicy.list.staleTimeMs instead.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

apps/dashboard/src/components/repo/code-file-view.tsx (1)

540-548: Consider centralizing commits-link construction.

This URL-param composition now exists in multiple components; extracting a small shared helper/component would reduce future drift (labeling, _splat shape, aria text).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/dashboard/src/components/repo/code-file-view.tsx` around lines 540 -
548, The commits link construction is duplicated; extract it into a small shared
helper or component (e.g., a buildCommitsLink(owner, repo, currentRef, path)
utility or a CommitsLink React component) and replace the inline Link usage in
code-file-view (the Link with params={{ owner, repo, _splat:
`${currentRef}/${path}` }}, aria-label="View commits", and visible label
"History"). The shared helper/component should return the same route shape
(to="/$owner/$repo/commits/$" and _splat `${currentRef}/${path}`) and preserve
aria-label and styling props so all callers (current and other components) use
the single source to avoid drift.

apps/dashboard/src/lib/github.functions.ts (1)

9672-9698: ⚠️ Potential issue | 🟠 Major

Use clampPage / clampPerPage here.

The current math still lets NaN, Infinity, and fractional values through, so page/perPage can become invalid in both the cache params and the listCommits call.

🛠️ Proposed fix

-		const perPage = Math.min(Math.max(data.perPage ?? 15, 1), 30);
-		const page = Math.max(data.page ?? 1, 1);
+		const perPage = Math.min(clampPerPage(data.perPage, 15), 30);
+		const page = clampPage(data.page);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/dashboard/src/lib/github.functions.ts` around lines 9672 - 9698, Replace
the ad-hoc Math.min/Math.max sanitization for perPage and page with the existing
clampPerPage and clampPage helpers so NaN, Infinity and fractional values are
normalized; call clampPerPage(data.perPage) to produce perPage and
clampPage(data.page) to produce page and use those sanitized values in the
params passed to getCachedGitHubRequest and in the
context.octokit.rest.repos.listCommits call (keeping the same namespace/signal
keys like githubRevalidationSignalKeys.repoCode(data) and freshForMs =
githubCachePolicy.detail.staleTimeMs).

apps/dashboard/src/components/repo/repo-commits-list.tsx (1)

303-305: Use a more descriptive avatar alt label.

Line 304 can be slightly clearer for assistive tech by labeling this as an avatar.

🪄 Small accessibility tweak

- alt={commit.author.login}
+ alt={`${commit.author.login} avatar`}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/dashboard/src/components/repo/repo-commits-list.tsx` around lines 303 -
305, The avatar image's alt text (in repo-commits-list.tsx where
src={commit.author.avatarUrl}) is currently just the username; update the alt
prop to a more descriptive label for assistive tech such as "Avatar of
{commit.author.login}" or "{commit.author.login} avatar" so screen readers
clearly announce that this is an avatar image.

apps/dashboard/src/lib/command-palette/use-command-items.ts (1)

208-225: Extract repository item construction into a shared helper.

Line 208 duplicates the same repo-to-CommandItem mapping used in Line 95, which increases drift risk when metadata/keywords change.

♻️ Proposed refactor

+function buildRepoCommandItem(repo: UserRepoSummary): CommandItem {
+	return {
+		id: `repo:${repo.id}`,
+		label: repo.fullName,
+		group: "Repositories",
+		icon: CodeIcon,
+		keywords: [repo.name, repo.owner, repo.language ?? ""].filter(Boolean),
+		action: {
+			type: "navigate",
+			to: `/${repo.owner}/${repo.name}`,
+		},
+		meta: {
+			language: repo.language,
+			stars: repo.stars,
+			updatedAt: repo.updatedAt ?? undefined,
+		},
+	};
+}
...
 	if (repos) {
 		for (const repo of repos) {
-			dynamicItems.push({
-				id: `repo:${repo.id}`,
-				label: repo.fullName,
-				group: "Repositories",
-				icon: CodeIcon,
-				keywords: [repo.name, repo.owner, repo.language ?? ""].filter(Boolean),
-				action: {
-					type: "navigate",
-					to: `/${repo.owner}/${repo.name}`,
-				},
-				meta: {
-					language: repo.language,
-					stars: repo.stars,
-					updatedAt: repo.updatedAt ?? undefined,
-				},
-			});
+			dynamicItems.push(buildRepoCommandItem(repo));
 		}
 	}
...
 	for (const repo of result.repos) {
-		items.push({
-			id: `repo:${repo.id}`,
-			label: repo.fullName,
-			group: "Repositories",
-			icon: CodeIcon,
-			keywords: [repo.name, repo.owner, repo.language ?? ""].filter(Boolean),
-			action: {
-				type: "navigate",
-				to: `/${repo.owner}/${repo.name}`,
-			},
-			meta: {
-				language: repo.language,
-				stars: repo.stars,
-				updatedAt: repo.updatedAt ?? undefined,
-			},
-		});
+		items.push(buildRepoCommandItem(repo));
 	}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/dashboard/src/lib/command-palette/use-command-items.ts` around lines 208
- 225, Extract the duplicated repo-to-CommandItem mapping into a single helper
(e.g., createRepoCommandItem or buildRepoCommandItem) and use it wherever repos
are mapped to command items (the places that currently do items.push({...}) for
result.repos). The helper should accept the repo object and return an object
with id: `repo:${repo.id}`, label: repo.fullName, group: "Repositories", icon:
CodeIcon, keywords: [repo.name, repo.owner, repo.language ??
""].filter(Boolean), action: { type: "navigate", to:
`/${repo.owner}/${repo.name}` }, and meta: { language: repo.language, stars:
repo.stars, updatedAt: repo.updatedAt ?? undefined }; replace both in-file
mappings with calls to this helper to avoid duplication and keep
metadata/keywords consistent.

apps/dashboard/src/lib/github.functions.ts (1)

444-469: Extract the shared repo-to-summary projection.

mapGithubSearchRepoToUserRepoSummary now duplicates almost all of mapGithubRestRepoToUserRepoSummary. Any future field tweak here is easy to miss in one path and not the other.

♻️ Suggested shape

+function mapRepoToUserRepoSummary(repo: {
+	id?: number;
+	name?: string | null;
+	full_name?: string | null;
+	description?: string | null;
+	stargazers_count?: number | null;
+	forks_count?: number | null;
+	language?: string | null;
+	updated_at?: string | null;
+	created_at?: string | null;
+	private?: boolean | null;
+	visibility?: string | null;
+	html_url?: string | null;
+	owner?: { login?: string | null } | null;
+}): UserRepoSummary {
+	const visibility: UserRepoSummary["visibility"] =
+		repo.visibility === "internal"
+			? "internal"
+			: repo.visibility === "private" || repo.private
+				? "private"
+				: "public";
+
+	return {
+		id: repo.id ?? 0,
+		name: repo.name ?? "",
+		fullName: repo.full_name ?? "",
+		description: repo.description ?? null,
+		stars: repo.stargazers_count ?? 0,
+		forks: repo.forks_count ?? 0,
+		language: repo.language ?? null,
+		updatedAt: repo.updated_at ?? null,
+		createdAt: repo.created_at ?? null,
+		isPrivate: Boolean(repo.private),
+		visibility,
+		url: repo.html_url ?? "",
+		owner: repo.owner?.login ?? "",
+	};
+}
+
 function mapGithubRestRepoToUserRepoSummary(
 	repo: AuthenticatedUserRepo | ListForUserRepo | GetRepoItem,
 ): UserRepoSummary {
-	...
+	return mapRepoToUserRepoSummary(repo);
 }
 
 function mapGithubSearchRepoToUserRepoSummary(
 	repo: SearchRepoItem,
 ): UserRepoSummary {
-	...
+	return mapRepoToUserRepoSummary(repo);
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/dashboard/src/lib/github.functions.ts` around lines 444 - 469, Duplicate
repo-to-summary logic exists between mapGithubSearchRepoToUserRepoSummary and
mapGithubRestRepoToUserRepoSummary; extract the shared projection into a single
helper used by both. Create a helper (e.g., buildUserRepoSummaryBase or
projectRepoToSummaryBase) that accepts a repo-like object and returns the common
fields (id, name, fullName, description, stars, forks, language, updatedAt,
createdAt, isPrivate, url, owner and visibility resolution logic if it is
identical); then replace the body of mapGithubSearchRepoToUserRepoSummary and
mapGithubRestRepoToUserRepoSummary to call that helper and apply any
mapper-specific overrides. Ensure you reference and use the existing symbols
mapGithubSearchRepoToUserRepoSummary and mapGithubRestRepoToUserRepoSummary so
callers are unchanged.

apps/dashboard/src/lib/github.functions.ts (1)

418-469: Extract a shared repo-summary mapper.

These two functions now duplicate nearly the entire UserRepoSummary mapping. A small shared helper would keep the REST and search shapes from drifting the next time this model changes.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/dashboard/src/lib/github.functions.ts` around lines 418 - 469, Both
mapGithubRestRepoToUserRepoSummary and mapGithubSearchRepoToUserRepoSummary
duplicate the same mapping logic; extract a shared helper (e.g.,
buildUserRepoSummaryFromRaw) that takes a minimal common input (an object with
id, name, full_name, description, stargazers_count, forks_count, language,
updated_at, created_at, private, visibility, html_url and owner?.login) and
returns a UserRepoSummary using the existing visibility logic and field
fallbacks; then have mapGithubRestRepoToUserRepoSummary (for
AuthenticatedUserRepo | ListForUserRepo | GetRepoItem) and
mapGithubSearchRepoToUserRepoSummary (for SearchRepoItem) normalize their shapes
into that helper (taking care that owner may be optional in SearchRepoItem and
repo.private may be absent) and delegate the final mapping to it.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes