#23

Fixing UB in fastpow

Openturboriumwants to merge intofrom

Fixing UB in fastpow

Activity

4
T
4ef5785
NoelJB9mo ago

I perceive that your intent is to ensure that the memory moves are correctly sized, but why not make the simpler fix of including stdint.h and changing the integer to int32_t? The float type is already standardized as 32-bit by IEEE.

Thoughts?

qasim786789mo ago

Good point, that would definitely be a cleaner and more readable fix. Using int32_t makes the intent explicit and avoids relying on assumptions about int size. I can update the patch to include <stdint.h> and switch to int32_t instead. Thanks for pointing that out.

dannythehumbleguy9mo ago

Top notch fix, It must be approved!