7d:I[154500,[["$2",["$3","$4","$5"],[14451,7897,23184]],["$6",["$7","$8","$9","$a","$b","$c"],[40076,49828,28925,10525,30632,53430]]],"IconMark"] 79:T7b8,Fixes #1679 Nine readers have the same shape: they read a UTF-8 file, and their handler lists `(OSError, json.JSONDecodeError)` while the behaviour below the `except` is "absent/empty". `UnicodeDecodeError` is a `ValueError`, so it matches neither slot and the exception leaves the call - which for the files below runs at startup (identity, subscription auth, viewer auth) or during artifact assembly (agent graph). Grouped by what the caller sees today: | reader | file | today | expected | |---|---|---|---| | `hydrate_todos_from_disk` | `todos.json` | run fails to start | store starts empty | | `hydrate_notes_from_disk` | `notes.json` | run fails to start | store starts empty | | `hydrate_threat_models_from_disk` | `threat_models.json` | run fails to start | store starts empty | | `hydrate_coverage_from_disk` | `coverage.json` | run fails to start | store starts empty | | `load_user_mcp_configs` | `mcp.json` | run fails to start | no connections | | `codex._read_store` | `subscription-auth.json` | auth read raises | `{}` | | `read_or_create_identity` | `identity.json` | run fails to start | a fresh identity | | `viewer_auth.read_auth` | `auth.json` | viewer raises | signed out | | `coverage.read_agent_graph` | `agents.json` | artifact assembly raises | `{}` | Each handler now lists `UnicodeDecodeError`, so the comment the code already promised ("unreadable; starting empty") is true for an undecodable file too. Validation: `pytest tests/test_undecodable_state_files.py -q` -> 10 passed; with the source changes stashed the same file gives 5 failed then 4 failed (one per group), so every case is load-bearing. `pytest tests/test_undecodable_state_files.py tests/test_inputs.py -q` -> 63 passed. ruff check + format clean. Found with a small AST scan for `(OSError, json.JSONDecodeError)` around a `read_text(encoding="utf-8")`: the remaining hits are write paths, or reads whose callers already fail loudly with a message, and those are left alone. 7a:T1231,

Confidence Score: 4/5

**[Medium impact]** The change is limited to five JSON\-loading paths used during scan setup\. The PR appears safe to merge, with a non\-blocking improvement needed in the healthy MCP test.

Findings

**Healthy loading is not tested** ▶

Fix with agent prompt

````markdown ### Issue 1 tests/test_undecodable_state_files.py:61-63 This test writes an object, but `load_user_mcp_configs` requires a list of server entries. It tests rejection rather than successful loading, so it would pass even if the loader always returned `[]`. Write a list containing a valid server and assert that the server is returned. ```suggestion path.write_text( json.dumps([{"name": "example", "url": "https://example.com/mcp"}]), encoding="utf-8" ) configs = mcp_loader.load_user_mcp_configs(path) assert len(configs) == 1 assert configs[0].name == "example" assert configs[0].url == "https://example.com/mcp" ``` --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly. ````

Summary

The PR catches `UnicodeDecodeError` in four state stores and the user's MCP configuration loader. - Scan setup and MCP loading continue when their JSON files cannot be decoded. _{Reviews (1) · Last reviewed commit: ["fix(tools): survive an undecodable state..."](https://github.com/usestrix/strix/commit/ceac90b516f6c938539f6b124e940c7ff35b4e05) · [Reviewed by Greptile](https://www.greptile.com/?utm_source=greptile_review&utm_medium=github&utm_campaign=review_public&utm_content=usestrix/strix)} 7b:T519,Small status note for whoever picks this up, since the PR is one change repeated nine times and that can look bigger than it is: - **The bug in one line**: a reader whose handler lists `(OSError, json.JSONDecodeError)` never catches `UnicodeDecodeError`, because that is a `ValueError`. The code below each handler already means "unreadable -> start empty", so the intent exists and only the catch list was short. - **Why it happens without tampering**: these files are written UTF-8 with `ensure_ascii=False`; a write interrupted mid-character leaves a file that is readable but not decodable. For `identity.json`, `subscription-auth.json` and `auth.json` that happens at startup. - **Shape of the diff**: nine one-line handler changes plus one new test file (`tests/test_undecodable_state_files.py`, 10 cases). Each case fails when its own handler change is reverted, so none of them is decorative. - **What I deliberately did not touch**: write paths, and reads whose callers already fail loudly with a message (for example `read_run_record`, which raises a `RuntimeError` naming the path) - changing those would hide real errors instead of reporting them. Happy to split it if you would rather review the tool stores and the startup files separately; say the word and I will re-cut it into two PRs. 63:["$","$L76",null,{"entries":[{"key":["platform",{"userId":"anon"},"pulls","page",{"owner":"usestrix","repo":"strix","pullNumber":1680}],"data":{"repositoryId":"5411","detail":{"author":{"avatarUrl":"https://cdn.trylle.com/media/images/07e7c42c343e54fc613bcf44d8583cf8?key=ATz9I1mlu4yuli48dhNH9ZmSiA3DwqrDwaZwl5FONQtthNBGK3zDvCYyBiXck%2Bvsg0SW0Hw5sqNSF8pG63BadyoicfQWS2%2FEm8PD69L1yF27puuMZ%2BEodcrpCUImCos9nrnIaxTnnKZsdymCXpHAwdJAs9Fx596%2FSyVnsHwjOFbF4p1ag4WkCOowbB4%3D","externalProvider":"github","login":"lxcxjxhx","type":"User","url":"https://github.com/lxcxjxhx"},"authorId":"144213008","baseRefName":"main","closedAt":null,"comments":4,"createdAt":"2026-11-07T09:52:58Z","headRefName":"lxcxjxhx/fix/undecodable-state-files","id":"4968528","isDraft":false,"labels":[],"number":1680,"repository":{"name":"strix","owner":"usestrix","provider":"forgejo"},"state":"open","title":"fix: treat an undecodable state file as absent, not as a fatal error","updatedAt":"2026-11-07T11:26:34Z","url":"https://trylle.com/usestrix/strix/pulls/1680","body":"$79","additions":111,"deletions":9,"changedFiles":10,"commits":2,"reviewComments":1,"headSha":"0f477dd4d7b9af2c0e78fd816e12ea80a8bdb045","baseSha":"215482eb2204cd30ac6b87520e3f5c6511e2e2e8","headRepoOwner":"usestrix","headRepoName":"strix","isMerged":false,"mergeCommitSha":null,"mergedBy":null,"mergeable":true,"mergeableState":"clean","conflictingFiles":null,"requestedTeams":[],"requestedReviewers":[],"graphqlId":"issue:1680","reactions":{"counts":{"+1":1},"viewerReacted":null,"userLoginsByContent":{"+1":["greptile-apps[bot](github)"]}}},"comments":[{"id":27078225,"graphqlId":"27078225","body":"$7a","createdAt":"2026-11-07T09:54:45Z","author":{"avatarUrl":"https://cdn.trylle.com/media/images/d5fdefbe765e9f429d38a31328621291?key=Acl0%2BlhblDOxCrSlqfonNDhgrt1LwjH88FRgEld3W8TJMWD14w5hVMk945%2FUo6%2F4SXM8sWkkR1IS3%2FPkJicqQw3Nzkwzis1r900F6Ii81AW%2B6%2FgoEHT7u6ClQhGHk5zI5yHvly2ZTjc6HDW38z1iK%2FBzByCTQdN9niTDbBlKfNdTv6bYqay%2Boc9at4A%3D","externalProvider":"github","login":"greptile-apps[bot]","type":"Bot","url":"https://github.com/apps/greptile-apps"}},{"id":27078226,"graphqlId":"27078226","body":"$7b","createdAt":"2026-11-07T11:18:43Z","author":{"avatarUrl":"https://cdn.trylle.com/media/images/07e7c42c343e54fc613bcf44d8583cf8?key=ATz9I1mlu4yuli48dhNH9ZmSiA3DwqrDwaZwl5FONQtthNBGK3zDvCYyBiXck%2Bvsg0SW0Hw5sqNSF8pG63BadyoicfQWS2%2FEm8PD69L1yF27puuMZ%2BEodcrpCUImCos9nrnIaxTnnKZsdymCXpHAwdJAs9Fx596%2FSyVnsHwjOFbF4p1ag4WkCOowbB4%3D","externalProvider":"github","login":"lxcxjxhx","type":"User","url":"https://github.com/lxcxjxhx"}},{"id":27078227,"graphqlId":"27078227","body":"Verification note, because the checks list can be misleading here: the repository's `CI` workflow (lint + pytest + tui) is in `action_required` for this PR, which means GitHub is waiting for a maintainer to approve the run for a fork. So the only green check on the PR is the third-party supply-chain scan, and no test has actually executed on CI yet.\n\nWhat I ran locally on this branch instead:\n\n- `pytest tests/test_undecodable_state_files.py -q` -> 10 passed\n- `pytest tests/test_undecodable_state_files.py tests/test_inputs.py -q` -> 63 passed\n- with each handler change reverted, the matching case fails (checked one group at a time: 5 failed / 1 passed, then 4 failed / 6 passed)\n- `ruff check` and `ruff format --check` clean on the touched files\n\nIf you approve the workflow run, `pytest` should be the one that matters; `mypy strix/` covers these files too and I could not run it here because the environment has no `uv`.\n","createdAt":"2026-11-07T11:26:34Z","author":{"avatarUrl":"https://cdn.trylle.com/media/images/07e7c42c343e54fc613bcf44d8583cf8?key=ATz9I1mlu4yuli48dhNH9ZmSiA3DwqrDwaZwl5FONQtthNBGK3zDvCYyBiXck%2Bvsg0SW0Hw5sqNSF8pG63BadyoicfQWS2%2FEm8PD69L1yF27puuMZ%2BEodcrpCUImCos9nrnIaxTnnKZsdymCXpHAwdJAs9Fx596%2FSyVnsHwjOFbF4p1ag4WkCOowbB4%3D","externalProvider":"github","login":"lxcxjxhx","type":"User","url":"https://github.com/lxcxjxhx"}}],"commits":[{"sha":"0f477dd4d7b9af2c0e78fd816e12ea80a8bdb045","message":"fix(interface): read an undecodable identity, auth and graph file as absent\n","createdAt":"2026-11-07T17:55:28+08:00","author":{"avatarUrl":"","login":"","name":"lxcxjxhx","type":"User","url":""},"verification":{"verified":false,"reason":"gpg.error.not_signed_commit"}},{"sha":"ceac90b516f6c938539f6b124e940c7ff35b4e05","message":"fix(tools): survive an undecodable state file instead of failing the run\n","createdAt":"2026-11-07T17:52:08+08:00","author":{"avatarUrl":"","login":"","name":"lxcxjxhx","type":"User","url":""},"verification":{"verified":false,"reason":"gpg.error.not_signed_commit"}}],"events":[{"id":27075374,"event":"reviewed","createdAt":"2026-11-07T09:54:49Z","actor":{"avatarUrl":"https://cdn.trylle.com/media/images/d5fdefbe765e9f429d38a31328621291?key=Acl0%2BlhblDOxCrSlqfonNDhgrt1LwjH88FRgEld3W8TJMWD14w5hVMk945%2FUo6%2F4SXM8sWkkR1IS3%2FPkJicqQw3Nzkwzis1r900F6Ii81AW%2B6%2FgoEHT7u6ClQhGHk5zI5yHvly2ZTjc6HDW38z1iK%2FBzByCTQdN9niTDbBlKfNdTv6bYqay%2Boc9at4A%3D","externalProvider":"github","login":"greptile-apps[bot]","type":"Bot","url":"https://github.com/apps/greptile-apps"},"reviewId":3651969,"reviewState":"COMMENT"}],"reviews":[{"id":3651969,"state":"COMMENT","author":{"avatarUrl":"https://cdn.trylle.com/media/images/d5fdefbe765e9f429d38a31328621291?key=Acl0%2BlhblDOxCrSlqfonNDhgrt1LwjH88FRgEld3W8TJMWD14w5hVMk945%2FUo6%2F4SXM8sWkkR1IS3%2FPkJicqQw3Nzkwzis1r900F6Ii81AW%2B6%2FgoEHT7u6ClQhGHk5zI5yHvly2ZTjc6HDW38z1iK%2FBzByCTQdN9niTDbBlKfNdTv6bYqay%2Boc9at4A%3D","externalProvider":"github","login":"greptile-apps[bot]","type":"Bot","url":"https://github.com/apps/greptile-apps"},"submittedAt":"2026-11-07T09:54:49Z","official":false}],"stackEvents":[],"commentPagination":{"totalCount":4,"perPage":30,"loadedPages":[1]},"eventPagination":{"loadedPages":[1],"hasMore":false},"headRefDeleted":false},"fetchedAt":1794163063262}],"children":"$L7c"}] 65:null 6c:[["$","title","0",{"children":"Commits · fix: treat an undecodable state file as absent, not as a fatal error · usestrix/strix | Trylle"}],["$","meta","1",{"name":"description","content":"Commits on fix: treat an undecodable state file as absent, not as a fatal error (#1680) in usestrix/strix."}],["$","meta","2",{"name":"application-name","content":"Trylle"}],["$","link","3",{"rel":"manifest","href":"/manifest.json","crossOrigin":"$undefined"}],["$","meta","4",{"name":"keywords","content":"Commits · fix: treat an undecodable state file as absent, not as a fatal error · usestrix/strix, usestrix/strix, usestrix/strix repository, strix, Python repository, source code, trylle, agent-native git platform, git platform for agents and humans, git platform for ai agents, coding agent pull requests, ai code review, repository automation, stacked pull requests, two-way github sync, github-compatible actions, try cli"}],["$","meta","5",{"name":"robots","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","6",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","7",{"name":"googlebot","content":"index, follow, max-image-preview:large, max-snippet:-1, max-video-preview:-1"}],["$","meta","8",{"name":"twitter:domain","content":"trylle.com"}],["$","meta","9",{"name":"twitter:url","content":"https://trylle.com/usestrix/strix/pulls/1680/commits"}],["$","link","10",{"rel":"canonical","href":"https://trylle.com/usestrix/strix/pulls/1680/commits"}],["$","meta","11",{"name":"format-detection","content":"telephone=no"}],["$","meta","12",{"name":"mobile-web-app-capable","content":"yes"}],["$","meta","13",{"name":"apple-mobile-web-app-title","content":"Trylle"}],["$","meta","14",{"name":"apple-mobile-web-app-status-bar-style","content":"black-translucent"}],["$","meta","15",{"property":"og:title","content":"Commits · fix: treat an undecodable state file as absent, not as a fatal error · usestrix/strix | Trylle"}],["$","meta","16",{"property":"og:description","content":"Commits on fix: treat an undecodable state file as absent, not as a fatal error (#1680) in usestrix/strix."}],["$","meta","17",{"property":"og:url","content":"https://trylle.com/usestrix/strix/pulls/1680/commits"}],["$","meta","18",{"property":"og:site_name","content":"Trylle"}],["$","meta","19",{"property":"og:locale","content":"en_US"}],["$","meta","20",{"property":"og:image","content":"https://trylle.com/api/og.png?kind=repo&owner=usestrix&repo=strix"}],["$","meta","21",{"property":"og:image:secure_url","content":"https://trylle.com/api/og.png?kind=repo&owner=usestrix&repo=strix"}],["$","meta","22",{"property":"og:image:type","content":"image/png"}],["$","meta","23",{"property":"og:image:width","content":"1200"}],["$","meta","24",{"property":"og:image:height","content":"630"}],["$","meta","25",{"property":"og:image:alt","content":"usestrix/strix repository preview on Trylle"}],["$","meta","26",{"property":"og:type","content":"website"}],["$","meta","27",{"name":"twitter:card","content":"summary_large_image"}],["$","meta","28",{"name":"twitter:site","content":"@trylle"}],["$","meta","29",{"name":"twitter:title","content":"Commits · fix: treat an undecodable state file as absent, not as a fatal error · usestrix/strix | Trylle"}],["$","meta","30",{"name":"twitter:description","content":"Commits on fix: treat an undecodable state file as absent, not as a fatal error (#1680) in usestrix/strix."}],["$","meta","31",{"name":"twitter:image","content":"https://trylle.com/api/og.png?kind=repo&owner=usestrix&repo=strix"}],["$","meta","32",{"name":"twitter:image:alt","content":"usestrix/strix repository preview on Trylle"}],["$","link","33",{"rel":"icon","href":"/favicon.png","type":"image/png"}],["$","link","34",{"rel":"icon","href":"/favicon-white.png","type":"image/png","media":"(prefers-color-scheme: dark)"}],["$","link","35",{"rel":"apple-touch-icon","href":"/logo192.png"}],["$","$L7d","36",{}]]

Commits on Sat, Nov 7, 2026