#20

TS no check on actions page

OpenThahaShahzadopened 2y ago

Is gemini not fully supported for generative UI? Could we fix this page to be type safe?

Activity

2
ruru-m072y ago

@ThahaShahzad I want to work it but I need more details what you want. Also I open 2 PR in this repo but no one review it.

Soo I think they stop make changes in this repo.

But I can still help you give me more information about your issue 😊

odysseaspapadimas2y ago

@ThahaShahzad It's easily fixable:

  • Update all necessary aiState maps
const history = aiState.get().messages.map((message: Message) => ({ //The Message type
    role: message.role,
    content: message.content
  }))
  • Go to the types.ts and update the Chat interface messages prop to point to that same type from actions.tsx

I think that's it? All of the flight components and stuff are very wrongly typed and I don't plan to use them so I just removed them

Slighly unrelated but since you kind of mentioned it @ruru-m07. The deployed app isn't even stable and it's really easily fixable, but I really wouldn't want to waste time creating PRs for a project that doesn't even check PRs, much less is maintained