#425

๐Ÿค– ๐Ÿ› Incorrect module hash comparison

Openasmit25805opened 4mo ago

๐Ÿ› Bug ยท ๐ŸŸ  High ยท Confidence: 98%

File: native/zero-c/src/program_graph_store_binary.c Location: binary_verify_graph_metadata


What's wrong

The function compares the provided module_hash against store->graph.graph_hash instead of the stored module hash, causing a false failure. The problematic line is: if (!binary_text_eq(module_hash, store->graph.graph_hash)) return binary_diag(diag, path, "repository graph module hash does not match stored graph", store->graph.graph_hash);

Suggested fix

Compare against store->graph.module_hash instead of store->graph.graph_hash. For example:

if (!binary_text_eq(module_hash, store->graph.module_hash))
    return binary_diag(diag, path, "repository graph module hash does not match stored graph", store->graph.module_hash);

About this report

This finding was generated by an automated audit tool using Llama 3.3 70B + verification passes. Only findings with โ‰ฅ92% confidence that passed both LLM self-verification and line reference verification are reported. False positives are still possible โ€” please verify before acting.

Activity

0

No activity yet.