Description
Use --type secret-key in CLI help and display Secret key in human-readable secret tables. Keep --type raw-value as a hidden parsing alias so existing scripts continue to work.
GraphQL enum variants, JSON output types and encrypted-envelope identifiers do not change. The UI companion is https://github.com/warpdotdev/warp-server/pull/20641; neither PR requires the other to deploy first.
Linked Issue
- The linked issue is labeled
ready-to-specorready-to-implement. — Factory App uses Triage until resolution, not readiness labels. - Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).
Testing
cargo nextest run -p warp_cli -E 'test(secret::tests)': 11 passed, covering default/canonical/legacy parsing and displayed help. cargo clippy -p warp_cli --all-targets --tests -- -D warnings and ./script/format passed.
- I have manually tested my changes locally with
./script/run— no desktop app build/run; the table-label change was inspected, and parser/help behavior was tested directly.
Screenshots / Videos
Media below demonstrates the companion web UI, not a desktop or CLI run.
Computer-use video recordings (2)
New Secret form: Type help and type switching: Hover/focus the Type help icon, dismiss with Escape, open the type dropdown, and switch among Secret key, registry, and harness credentials, then back to Secret key.
New Factory secret Type help flow: Keyboard-focus Type help, Escape dismissal, hover, dropdown options, and switching secret types on new Factory.
Computer-use screenshots (10)
Narrow (390px) viewport: Type help tooltip open via keyboard focus, fits within viewport but covers select/Value/Description fields
Factory legacy (3005) Add secret pane with Type help tooltip open, listing all type descriptions, overlapping the Type select/Name field
Factory legacy at 390px viewport: Add secret pane with Type help tooltip open, fits within viewport with no clipping
Agents (3002) Add secret pane with Type help tooltip open (3 types), overlapping the Type select and Name field
Agents at 390px viewport: Add secret pane with Type help tooltip open, fully visible, no clipping or horizontal overflow
New Factory: Type help tooltip open via keyboard focus with focus ring visible
New Factory Type dropdown open with all 7 options
New Factory at 390px viewport: Type help tooltip open via keyboard focus, within viewport
Legacy Factory Add secret: Type help open via keyboard focus with focus ring
Agents Add secret: Type help open via keyboard focus with blue focus ring
Agent Mode
- Warp Agent Mode - This PR was created via Warp's AI Agent Mode
CHANGELOG-IMPROVEMENT: Secrets shown as Raw value are now called Secret key. Existing --type raw-value CLI commands remain compatible.
This PR was generated with Warp.
Comment
@warp-staging-factoryon this PR to send it follow-up work.